From: Vidya Sagar <vidyas@nvidia.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Colin King <colin.king@canonical.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
<linux-pci@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] PCI: tegra: tegra194: fix phy_count less than zero check
Date: Wed, 21 Aug 2019 20:31:42 +0530 [thread overview]
Message-ID: <b9f4dc94-a3d6-5748-128d-9df6dc990eb8@nvidia.com> (raw)
In-Reply-To: <20190821140520.GA691@e121166-lin.cambridge.arm.com>
On 8/21/2019 7:35 PM, Lorenzo Pieralisi wrote:
> On Wed, Aug 21, 2019 at 01:01:23PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The check for pcie->phy_count < 0 is always false because phy_count
>> is an unsigned int and can never be less than zero. Fix this by
>> assigning ret to the return from of_property_count_strings and
>> checking if this is less than zero instead.
>>
>> Addresses-Coverity: ("Dead code")
>> Fixes: 6404441c8e13 ("PCI: tegra: Add Tegra194 PCIe support")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/pci/controller/dwc/pcie-tegra194.c | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> Squashed in the original commit (it is not merged yet), thanks
> for reporting it.
Thanks Colin for catching it and pushing a fix also.
Thanks Lorenzo for merging it.
Apologies for missing this in my patch series.
>
> Lorenzo
>
>> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
>> index fc0dbeb31d78..b47ea3e68303 100644
>> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
>> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
>> @@ -969,12 +969,13 @@ static int tegra_pcie_dw_parse_dt(struct tegra_pcie_dw *pcie)
>> return ret;
>> }
>>
>> - pcie->phy_count = of_property_count_strings(np, "phy-names");
>> - if (pcie->phy_count < 0) {
>> + ret = of_property_count_strings(np, "phy-names");
>> + if (ret < 0) {
>> dev_err(pcie->dev, "Failed to find PHY entries: %d\n",
>> - pcie->phy_count);
>> - return pcie->phy_count;
>> + ret);
>> + return ret;
>> }
>> + pcie->phy_count = ret;
>>
>> if (of_property_read_bool(np, "nvidia,update-fc-fixup"))
>> pcie->update_fc_fixup = true;
>> --
>> 2.20.1
>>
prev parent reply other threads:[~2019-08-21 15:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 12:01 [PATCH][next] PCI: tegra: tegra194: fix phy_count less than zero check Colin King
2019-08-21 12:43 ` Thierry Reding
2019-08-21 14:05 ` Lorenzo Pieralisi
2019-08-21 15:01 ` Vidya Sagar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9f4dc94-a3d6-5748-128d-9df6dc990eb8@nvidia.com \
--to=vidyas@nvidia.com \
--cc=bhelgaas@google.com \
--cc=colin.king@canonical.com \
--cc=jonathanh@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).