Linux-PCI Archive on
 help / color / Atom feed
From: Benjamin Herrenschmidt <>
To: linux-pci <>
Cc: Bjorn Helgaas <>,
	Richard Henderson <>,
	Matt Turner <>
Subject: IORESOURCE_PCI_FIXES & __pci_bus_assign_resources()
Date: Mon, 17 Jun 2019 18:35:16 +1000
Message-ID: <> (raw)

Hi !

While working on consolidating resource assignment, I stumbled upon
something alpha does (and maybe others I haven't spotted yet):

On most platforms (not all), it uses the usual pair:


to reassign everything.

However, before doing so, it first calls pcibios_claim_one_bus() which,
on those platforms (ie those who don't set PCI_PROBE_ONLY), will
effectively claim only resources that have IORESOURCE_PCI_FIXED.

Now, let's leave alone for now the fact that this is will really only
work if those resources aren't behind a bridge as, to the best of my
undertanding of the code at this point, we aren't going to take them
into account when sizing & locating bridges. But that's not my point
right now :-)

From what I can tell, these days, pci_bus_assign_resources() will
already claim those fixed resources via pdev_assign_fixed_resources().

However, it does so *after* it has assigned and claimed resoures for
all the sibling devices on that bus.

That looks wrong to me. Shouldn't we claim the fixed resources first ?
IE something like:

--- a/drivers/pci/setup-bus.c
+++ b/drivers/pci/setup-bus.c
@@ -1345,11 +1345,12 @@ void __pci_bus_assign_resources(const struct pci_bus *bus,
 	struct pci_bus *b;
 	struct pci_dev *dev;
+	list_for_each_entry(dev, &bus->devices, bus_list)
+		pdev_assign_fixed_resources(dev);
 	pbus_assign_resources_sorted(bus, realloc_head, fail_head);
 	list_for_each_entry(dev, &bus->devices, bus_list) {
-		pdev_assign_fixed_resources(dev);
 		b = dev->subordinate;
 		if (!b)

Now, I suspect most of the time it happens to work due to the fact that
the fixed resources are generally IO resources in the legacy low ranges
( < 0x1000) and PCIBIOS_MIN_IO is *generally* set to 0x1000 but it still
sounds fishy to me.

I don't think I have HW at hand with that type of fixed stuff to test
with at the moment, so this is very much academic right now but I worry
that when I convert archs such as alpha who does that claiming before
the rest of the assignment, switching doing things the other way around
will break.

Any thoughts ?


                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PCI Archive on

Archives are clonable:
	git clone --mirror linux-pci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pci linux-pci/ \
	public-inbox-index linux-pci

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox