From: Max Gurtovoy <maxg@mellanox.com>
To: Oliver O'Halloran <oohall@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-pci@vger.kernel.org,
Frederic Barrat <fbarrat@linux.ibm.com>,
Carol L Soto <clsoto@us.ibm.com>,
idanw@mellanox.com, aneela@mellanox.com, shlomin@mellanox.com
Subject: Re: [PATCH 2/2] powerpc/powernv: Enable and setup PCI P2P
Date: Sun, 19 Apr 2020 14:46:22 +0300 [thread overview]
Message-ID: <beef6318-ca4d-10c1-cb08-1de06e484a8a@mellanox.com> (raw)
In-Reply-To: <CAOSf1CHdepTVZUE0=H0P3vLTY820wyiLGuKM_qOjv9kguS3Zww@mail.gmail.com>
On 4/17/2020 5:04 PM, Oliver O'Halloran wrote:
> On Fri, Apr 17, 2020 at 9:17 PM Max Gurtovoy <maxg@mellanox.com> wrote:
>>> The enable and disable path shares almost no code, why not split it into
>>> two functions?
>> how about also changing the defines OPAL_PCI_P2P_* to an enum ?
>>
>> /* PCI p2p operation descriptors */
>> enum opal_pci_p2p {
>>
>> OPAL_PCI_P2P_DISABLE = 0,
>>
>> OPAL_PCI_P2P_ENABLE = (1 << 0),
>> OPAL_PCI_P2P_LOAD = (1 << 1),
>> OPAL_PCI_P2P_STORE = (1 << 2),
>> };
>>
>> Fred ?
> I'd rather you didn't. We try to keep the definitions in opal-api.h
> the same as the skiboot's opal-api.h since the skiboot version is
> canonical.
>
> Also, generally patches to anything PowerNV related go through the
> powerpc tree rather than the pci tree even if they're PCI related. Can
> you make sure you have linuxppc-dev CCed when you post v2.
Sure, no problem.
>
> Oliver
next prev parent reply other threads:[~2020-04-19 11:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 16:57 [PATCH 1/2] powerpc/dma: Define map/unmap mmio resource callbacks Max Gurtovoy
2020-04-16 16:57 ` [PATCH 2/2] powerpc/powernv: Enable and setup PCI P2P Max Gurtovoy
2020-04-17 7:02 ` Christoph Hellwig
2020-04-17 11:16 ` Max Gurtovoy
2020-04-17 14:04 ` Oliver O'Halloran
2020-04-19 11:46 ` Max Gurtovoy [this message]
2020-04-17 6:55 ` [PATCH 1/2] powerpc/dma: Define map/unmap mmio resource callbacks Christoph Hellwig
2020-04-19 10:14 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=beef6318-ca4d-10c1-cb08-1de06e484a8a@mellanox.com \
--to=maxg@mellanox.com \
--cc=aneela@mellanox.com \
--cc=clsoto@us.ibm.com \
--cc=fbarrat@linux.ibm.com \
--cc=hch@lst.de \
--cc=idanw@mellanox.com \
--cc=linux-pci@vger.kernel.org \
--cc=oohall@gmail.com \
--cc=shlomin@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).