From: Dongdong Liu <liudongdong3@huawei.com>
To: <helgaas@kernel.org>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] PCI: Support BAR sizes up to 8TB
Date: Thu, 3 Mar 2022 21:19:17 +0800 [thread overview]
Message-ID: <c1216b26-ea4a-34b9-9513-182be3cd0251@huawei.com> (raw)
In-Reply-To: <20220118092117.10089-1-liudongdong3@huawei.com>
Hi Bjorn
Could you help to review this patch, I hope this patch can be applied
for 5.18.
Thanks,
Dongdong
On 2022/1/18 17:21, Dongdong Liu wrote:
> Current kernel reports disabling BAR if device with a 4TB BAR as it
> only supports BAR size to 128GB.
>
> pci 0000:01:00.0: disabling BAR 4:
> [mem 0x00000000-0x3ffffffffff 64bit pref] (bad alignment 0x40000000000)
>
> Increase the maximum BAR size from 128GB to 8TB for future expansion.
>
> Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
> ---
> drivers/pci/setup-bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
> index 547396ec50b5..a7893bf2f580 100644
> --- a/drivers/pci/setup-bus.c
> +++ b/drivers/pci/setup-bus.c
> @@ -994,7 +994,7 @@ static int pbus_size_mem(struct pci_bus *bus, unsigned long mask,
> {
> struct pci_dev *dev;
> resource_size_t min_align, align, size, size0, size1;
> - resource_size_t aligns[18]; /* Alignments from 1MB to 128GB */
> + resource_size_t aligns[24]; /* Alignments from 1MB to 8TB */
> int order, max_order;
> struct resource *b_res = find_bus_resource_of_type(bus,
> mask | IORESOURCE_PREFETCH, type);
>
next prev parent reply other threads:[~2022-03-03 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 9:21 [PATCH] PCI: Support BAR sizes up to 8TB Dongdong Liu
2022-02-15 11:32 ` Dongdong Liu
2022-03-03 13:19 ` Dongdong Liu [this message]
2022-03-03 18:11 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1216b26-ea4a-34b9-9513-182be3cd0251@huawei.com \
--to=liudongdong3@huawei.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).