From: Joe Perches <joe@perches.com>
To: Alex_Gagniuc@Dellteam.com, lukas@wunner.de, mr.nuke.me@gmail.com
Cc: bhelgaas@google.com, Austin.Bolen@dell.com,
keith.busch@intel.com, Shyam.Iyer@dell.com, okaya@kernel.org,
linux-pci@vger.kernel.org, mika.westerberg@linux.intel.com,
okaya@codeaurora.org, poza@codeaurora.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v2 4/4] PCI: hotplug: Add quirk For Dell nvme pcie switches
Date: Thu, 21 Feb 2019 17:20:19 -0800 [thread overview]
Message-ID: <c238a08cfaae0bd09e434edc889b0ecab50aee24.camel@perches.com> (raw)
In-Reply-To: <027101b4652c4e0c98b86649aa3e4732@ausx13mps321.AMER.DELL.COM>
On Thu, 2019-02-21 at 18:35 +0000, Alex_Gagniuc@Dellteam.com wrote:
> On 2/21/19 1:57 AM, Lukas Wunner wrote:
> > On Tue, Feb 19, 2019 at 07:20:30PM -0600, Alexandru Gagniuc wrote:
> > > --- a/drivers/pci/hotplug/pciehp_hpc.c
> > >
> > > +}
> > > +
> > > +DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_PLX, 0x9733,
> >
> > By convention there's no blank line between the closing curly brace
> > and the DECLARE_PCI_FIXUP_CLASS_FINAL().
Not completely true.
See: arch/mips/pci/fixup-loongson3.c
> I'm sorry for all the style issues. I realize it's noise and should just
> be done right from the beginning. Is there a way to make checkpatch.pl
> catch these before they go out?
You could write a new rule, but it's non trivial as
there are multiple consecutive uses and multi-line
uses too.
I think it's a rule not worth writing.
next prev parent reply other threads:[~2019-02-22 1:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 1:20 [PATCH RFC v2 0/4] PCI: pciehp: Do not turn off slot if presence comes up after link Alexandru Gagniuc
2019-02-20 1:20 ` [PATCH RFC v2 1/4] PCI: hotplug: Add support for disabling in-band presence Alexandru Gagniuc
2019-02-21 7:19 ` Lukas Wunner
2019-02-21 18:05 ` Alex_Gagniuc
2019-02-20 1:20 ` [PATCH RFC v2 2/4] PCI: pciehp: Do not turn off slot if presence comes up after link Alexandru Gagniuc
2019-02-21 7:36 ` Lukas Wunner
2019-02-22 19:56 ` Alex_Gagniuc
2019-02-23 6:49 ` Lukas Wunner
2019-02-24 22:27 ` Alex_Gagniuc
2019-02-20 1:20 ` [PATCH RFC v2 3/4] PCI: hotplug: Wait for PDS when in-band presence is disabled Alexandru Gagniuc
2019-02-20 1:20 ` [PATCH RFC v2 4/4] PCI: hotplug: Add quirk For Dell nvme pcie switches Alexandru Gagniuc
2019-02-21 7:56 ` Lukas Wunner
2019-02-21 18:35 ` Alex_Gagniuc
2019-02-22 1:20 ` Joe Perches [this message]
2019-02-22 2:04 ` Oliver
2019-02-22 19:19 ` Alex_Gagniuc
2019-02-21 15:38 ` [PATCH RFC v2 0/4] PCI: pciehp: Do not turn off slot if presence comes up after link Lukas Wunner
2019-02-21 18:17 ` Alex_Gagniuc
2019-04-19 0:01 ` Bjorn Helgaas
2019-04-19 15:22 ` [PATCH v3 " Alexandru Gagniuc
2019-04-19 15:22 ` [PATCH v3 1/4] PCI: hotplug: Add support for disabling in-band presence Alexandru Gagniuc
2019-04-19 15:22 ` [PATCH v3 2/4] PCI: pciehp: Do not turn off slot if presence comes up after link Alexandru Gagniuc
2019-04-19 15:22 ` [PATCH v3 3/4] PCI: hotplug: Wait for PDS when in-band presence is disabled Alexandru Gagniuc
2019-04-19 15:22 ` [PATCH v3 4/4] PCI: hotplug: Add quirk For Dell nvme pcie switches Alexandru Gagniuc
2019-04-19 21:00 ` Alan J. Wylie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c238a08cfaae0bd09e434edc889b0ecab50aee24.camel@perches.com \
--to=joe@perches.com \
--cc=Alex_Gagniuc@Dellteam.com \
--cc=Austin.Bolen@dell.com \
--cc=Shyam.Iyer@dell.com \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=mr.nuke.me@gmail.com \
--cc=okaya@codeaurora.org \
--cc=okaya@kernel.org \
--cc=poza@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).