On 27/10/2020 18:20, Bjorn Helgaas wrote: > [+cc vtolkm] > > On Tue, Oct 27, 2020 at 04:43:20PM +0100, Toke Høiland-Jørgensen wrote: >> Hi everyone >> >> I'm trying to get a mainline kernel to run on my Turris Omnia, and am >> having some trouble getting the PCI bus to work correctly. Specifically, >> I'm running a 5.10-rc1 kernel (torvalds/master as of this moment), with >> the resource request fix[0] applied on top. >> >> The kernel boots fine, and the patch in [0] makes the PCI devices show >> up. But I'm still getting initialisation errors like these: >> >> [ 1.632709] pci 0000:01:00.0: BAR 0: error updating (0xe0000004 != 0xffffffff) >> [ 1.632714] pci 0000:01:00.0: BAR 0: error updating (high 0x000000 != 0xffffffff) >> [ 1.632745] pci 0000:02:00.0: BAR 0: error updating (0xe0200004 != 0xffffffff) >> [ 1.632750] pci 0000:02:00.0: BAR 0: error updating (high 0x000000 != 0xffffffff) >> >> and the WiFi drivers fail to initialise with what appears to me to be >> errors related to the bus rather than to the drivers themselves: >> >> [ 3.509878] ath: phy0: Mac Chip Rev 0xfffc0.f is not supported by this driver >> [ 3.517049] ath: phy0: Unable to initialize hardware; initialization status: -95 >> [ 3.524473] ath9k 0000:01:00.0: Failed to initialize device >> [ 3.530081] ath9k: probe of 0000:01:00.0 failed with error -95 >> [ 3.536012] ath10k_pci 0000:02:00.0: of_irq_parse_pci: failed with rc=134 >> [ 3.543049] pci 0000:00:02.0: enabling device (0140 -> 0142) >> [ 3.548735] ath10k_pci 0000:02:00.0: can't change power state from D3hot to D0 (config space inaccessible) >> [ 3.588592] ath10k_pci 0000:02:00.0: failed to wake up device : -110 >> [ 3.595098] ath10k_pci: probe of 0000:02:00.0 failed with error -110 >> >> lspci looks OK, though: >> >> # lspci >> 00:01.0 PCI bridge: Marvell Technology Group Ltd. Device 6820 (rev 04) >> 00:02.0 PCI bridge: Marvell Technology Group Ltd. Device 6820 (rev 04) >> 00:03.0 PCI bridge: Marvell Technology Group Ltd. Device 6820 (rev 04) >> 01:00.0 Network controller: Qualcomm Atheros AR9287 Wireless Network Adapter (PCI-Express) (rev 01) >> 02:00.0 Network controller: Qualcomm Atheros QCA986x/988x 802.11ac Wireless Network Adapter (rev ff) >> >> Does anyone have any clue what could be going on here? Is this a bug, or >> did I miss something in my config or other initialisation? I've tried >> with both the stock u-boot distributed with the board, and with an >> upstream u-boot from latest master; doesn't seem to make any different. > Can you try turning off CONFIG_PCIEASPM? We had a similar recent > report at https://bugzilla.kernel.org/show_bug.cgi?id=209833 but I > don't think we have a fix yet. > Got the same device working with > 5.10.0-rc1-next-20201027-to-dirty < but ASPM turned off, as mentioned in the cited bug report.  dmesg | grep ath ath10k_pci 0000:02:00.0: enabling device (0140 -> 0142) ath10k_pci 0000:02:00.0: pci irq msi oper_irq_mode 2 irq_mode 0 reset_mode 0 ath10k_pci 0000:02:00.0: qca988x hw2.0 target 0x4100016c chip_id 0x043202ff sub 0000:0000 ath9k 0000:03:00.0: enabling device (0140 -> 0142) ath10k_pci 0000:02:00.0: kconfig debug 1 debugfs 0 tracing 1 dfs 0 testmode 0 ath10k_pci 0000:02:00.0: firmware ver 10.2.4-1.0-00047 api 5 features no-p2p,raw-mode,mfp,allows-mesh-bcast crc32 35bd9258 ath: EEPROM regdomain sanitized ath: EEPROM regdomain: 0x64 ath: EEPROM indicates we should expect a direct regpair map ath: Country alpha2 being used: 00 ath: Regpair used: 0x64 ath10k_pci 0000:02:00.0: board_file api 1 bmi_id N/A crc32 bebc7c08 ath10k_pci 0000:02:00.0: htt-ver 2.1 wmi-op 5 htt-op 2 cal otp max-sta 128 raw 0 hwcrypto 1 ath: EEPROM regdomain sanitized ath: EEPROM regdomain: 0x64 ath: EEPROM indicates we should expect a direct regpair map ath: Country alpha2 being used: 00 ath: Regpair used: 0x64 ath10k_pci 0000:02:00.0: pdev param 0 not supported by firmware ---- Note: related issues - workaround compile ath and cfg80211 as modules (1) https://bugzilla.kernel.org/show_bug.cgi?id=209863 (2) https://bugzilla.kernel.org/show_bug.cgi?id=209855 (3) https://bugzilla.kernel.org/show_bug.cgi?id=209853