Linux-PCI Archive on lore.kernel.org
 help / color / Atom feed
From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Ansuel Smith <ansuelsmth@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Andrew Murray <amurray@thegoodpenguin.co.uk>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 00/12] Multiple fixes in PCIe qcom driver
Date: Tue, 7 Jul 2020 17:57:28 +0300
Message-ID: <c4407d40-3b9b-5e79-9bf7-5947ce9178e3@mm-sol.com> (raw)
In-Reply-To: <20200707140516.GC17163@e121166-lin.cambridge.arm.com>

Hi Lorenzo,

On 7/7/20 5:05 PM, Lorenzo Pieralisi wrote:
> On Mon, Jun 15, 2020 at 11:05:56PM +0200, Ansuel Smith wrote:
>> This contains multiple fix for PCIe qcom driver.
>> Some optional reset and clocks were missing.
>> Fix a problem with no PARF programming that cause kernel lock on load.
>> Add support to force gen 1 speed if needed. (due to hardware limitation)
>> Add ipq8064 rev 2 support that use a different tx termination offset.
>>
>> v7:
>> * Rework GEN1 patch
>>
>> v6:
>> * Replace custom define
>> * Move define not used in 07 to 08
>>
>> v5:
>> * Split PCI: qcom: Add ipq8064 rev2 variant and set tx term offset
>>
>> v4:
>> * Fix grammar error across all patch subject
>> * Use bulk api for clks
>> * Program PARF only in ipq8064 SoC
>> * Program tx term only in ipq8064 SoC
>> * Drop configurable tx-dempth rx-eq
>> * Make added clk optional
>>
>> v3:
>> * Fix check reported by checkpatch --strict
>> * Rename force_gen1 to gen
>>
>> v2:
>> * Drop iATU programming (already done in pcie init)
>> * Use max-link-speed instead of force-gen1 custom definition
>> * Drop MRRS to 256B (Can't find a realy reason why this was suggested)
>> * Introduce a new variant for different revision of ipq8064
>>
>> Abhishek Sahu (1):
>>   PCI: qcom: Change duplicate PCI reset to phy reset
>>
>> Ansuel Smith (10):
>>   PCI: qcom: Add missing ipq806x clocks in PCIe driver
>>   dt-bindings: PCI: qcom: Add missing clks
>>   PCI: qcom: Add missing reset for ipq806x
>>   dt-bindings: PCI: qcom: Add ext reset
>>   PCI: qcom: Use bulk clk api and assert on error
>>   PCI: qcom: Define some PARF params needed for ipq8064 SoC
>>   PCI: qcom: Add support for tx term offset for rev 2.1.0
>>   PCI: qcom: Add ipq8064 rev2 variant
>>   dt-bindings: PCI: qcom: Add ipq8064 rev 2 variant
>>   PCI: qcom: Replace define with standard value
>>
>> Sham Muthayyan (1):
>>   PCI: qcom: Support pci speed set for ipq806x
>>
>>  .../devicetree/bindings/pci/qcom,pcie.txt     |  15 +-
>>  drivers/pci/controller/dwc/pcie-qcom.c        | 186 +++++++++++-------
>>  2 files changed, 128 insertions(+), 73 deletions(-)
> 
> ACK missing on patches 8,9,12 please let me know how to proceed,
> thanks.

You could use my acked-by for them:

Acked-by: Stanimir Varbanov <svarbanov@mm-sol.com>

> 
> Lorenzo
> 

-- 
regards,
Stan

  reply index

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15 21:05 Ansuel Smith
2020-06-15 21:05 ` [PATCH v7 01/12] PCI: qcom: Add missing ipq806x clocks in PCIe driver Ansuel Smith
2020-06-15 21:05 ` [PATCH v7 02/12] dt-bindings: PCI: qcom: Add missing clks Ansuel Smith
2020-06-15 21:05 ` [PATCH v7 03/12] PCI: qcom: Change duplicate PCI reset to phy reset Ansuel Smith
2020-06-15 21:06 ` [PATCH v7 04/12] PCI: qcom: Add missing reset for ipq806x Ansuel Smith
2020-06-15 21:06 ` [PATCH v7 05/12] dt-bindings: PCI: qcom: Add ext reset Ansuel Smith
2020-06-15 21:06 ` [PATCH v7 06/12] PCI: qcom: Use bulk clk api and assert on error Ansuel Smith
2020-06-15 21:06 ` [PATCH v7 07/12] PCI: qcom: Define some PARF params needed for ipq8064 SoC Ansuel Smith
2020-06-15 21:06 ` [PATCH v7 08/12] PCI: qcom: Add support for tx term offset for rev 2.1.0 Ansuel Smith
2020-06-15 21:06 ` [PATCH v7 09/12] PCI: qcom: Add ipq8064 rev2 variant Ansuel Smith
2020-06-15 21:06 ` [PATCH v7 10/12] dt-bindings: PCI: qcom: Add ipq8064 rev 2 variant Ansuel Smith
2020-06-15 21:06 ` [PATCH v7 11/12] PCI: qcom: Support pci speed set for ipq806x Ansuel Smith
2020-06-15 21:06 ` [PATCH v7 12/12] PCI: qcom: Replace define with standard value Ansuel Smith
2020-06-25 23:37 ` [PATCH v7 00/12] Multiple fixes in PCIe qcom driver Stanimir Varbanov
2020-07-07 14:05 ` Lorenzo Pieralisi
2020-07-07 14:57   ` Stanimir Varbanov [this message]
2020-07-07 15:15 ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4407d40-3b9b-5e79-9bf7-5947ce9178e3@mm-sol.com \
    --to=svarbanov@mm-sol.com \
    --cc=agross@kernel.org \
    --cc=amurray@thegoodpenguin.co.uk \
    --cc=ansuelsmth@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PCI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \
		linux-pci@vger.kernel.org
	public-inbox-index linux-pci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git