From: Don Dutile <ddutile@redhat.com>
To: Hanjun Guo <guohanjun@huawei.com>, Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH] PCI: Put the IVRS table in AMD ACS quirk handler
Date: Thu, 30 Jul 2020 12:30:22 -0400 [thread overview]
Message-ID: <c482514b-7156-dc7a-94e1-df004fa9185d@redhat.com> (raw)
In-Reply-To: <74348feb-5646-6d33-1a84-532f9179df78@huawei.com>
On 7/30/20 2:14 AM, Hanjun Guo wrote:
> On 2020/7/30 7:02, Bjorn Helgaas wrote:
>> [+cc Alex, Don]
>>
>> On Wed, Jul 22, 2020 at 05:44:28PM +0800, Hanjun Guo wrote:
>>> The acpi_get_table() should be coupled with acpi_put_table() if
>>> the mapped table is not used at runtime to release the table
>>> mapping.
>>>
>>> In pci_quirk_amd_sb_acs(), IVRS table is just used for checking
>>> AMD IOMMU is supported, not used at runtime, put the table after
>>> using it.
>>>
>>> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
>>
>> Applied to pci/virtualization for v5.9, thanks!
>>
>> I added this:
>>
>> Fixes: 15b100dfd1c9 ("PCI: Claim ACS support for AMD southbridge devices")
>>
>> but I didn't add a stable tag. Does this cause any issue that would
>> warrant a stable tag?
>
For most of our (bug-fix & functional backport tooling) we focus on 'Fixes' and not
specific stable tagging, since our kernel becomes quite a mix of upstream once we venture much past the RHEL-X.0 GA.
I have seen others that use/reference the stable trees as another sanity check; or a way to
modify a RHEL kernel source into their own private use. Thus, RHEL doesn't have as strong a dependency on stable, as much as it does upstream-tip.
> We don't have one when I was sending same function patch for ACPI
> subsystem, so I think it's OK to without a stable tag for this
> patch as well.
>
> Thanks
> Hanjun
>
prev parent reply other threads:[~2020-07-30 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 9:44 [PATCH] PCI: Put the IVRS table in AMD ACS quirk handler Hanjun Guo
2020-07-29 23:02 ` Bjorn Helgaas
2020-07-30 6:14 ` Hanjun Guo
2020-07-30 16:30 ` Don Dutile [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c482514b-7156-dc7a-94e1-df004fa9185d@redhat.com \
--to=ddutile@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=guohanjun@huawei.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).