archive mirror
 help / color / mirror / Atom feed
From: Felix Fietkau <>
To: Bjorn Helgaas <>
Cc: "Ryder Lee" <>,
	"Jianjun Wang" <>,
	"Lorenzo Pieralisi" <>,
	"Rob Herring" <>,
	"Krzysztof Wilczyński" <>,
	"Bjorn Helgaas" <>,
	"Matthias Brugger" <>,,,,
Subject: Re: [PATCH] PCI: mediatek-gen3: change driver name to mtk-pcie-gen3
Date: Wed, 4 May 2022 19:16:40 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20220504170658.GA453994@bhelgaas>

On 04.05.22 19:06, Bjorn Helgaas wrote:
> On Wed, May 04, 2022 at 12:05:55PM +0200, Felix Fietkau wrote:
>> This allows it to coexist with the other mtk pcie driver in the same kernel
> I assume this is a v3 of [1].  Please:
Thanks, I wasn't aware of that patch.

>    - Follow the subject line capitalization convention, i.e.,
>      "PCI: mediatek-gen3: Change ..."
>    - Expand the commit log to say why this is important.  From a C
>      language level, using the same "mtk-pcie" string in both drivers
>      is no problem.  So please mention where it *is* a problem, e.g.,
>      if it's a problem with modprobe or similar, say that.  Or if it's
>      to make log messages in dmesg have different driver names, say
>      that.The reason is the fact that driver_register will refuse to register a 
driver if one with the same name has already been registered.

>    - s/pcie/PCIe/ in commit log and other English text.
>    - Add a period at the end of the commit log sentence.
> [1]
Will take care of this and send an updated version as v3.

- Felix

  reply	other threads:[~2022-05-04 17:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-04 10:05 [PATCH] PCI: mediatek-gen3: change driver name to mtk-pcie-gen3 Felix Fietkau
2022-05-04 17:06 ` Bjorn Helgaas
2022-05-04 17:16   ` Felix Fietkau [this message]
2022-10-08 16:42 Frank Wunderlich
2022-10-10 20:53 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).