From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8D2FC433F5 for ; Thu, 30 Sep 2021 19:50:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A788661A3B for ; Thu, 30 Sep 2021 19:50:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347607AbhI3TwK (ORCPT ); Thu, 30 Sep 2021 15:52:10 -0400 Received: from mga06.intel.com ([134.134.136.31]:34250 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345816AbhI3TwE (ORCPT ); Thu, 30 Sep 2021 15:52:04 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10123"; a="286294774" X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="286294774" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 12:50:16 -0700 X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="480065078" Received: from rnmathur-mobl1.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.212.105.173]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 12:50:15 -0700 Subject: Re: [PATCH v2 1/6] driver core: Move the "authorized" attribute from USB/Thunderbolt to core To: Dan Williams , Yehezkel Bernat Cc: Greg Kroah-Hartman , Borislav Petkov , X86 ML , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Andreas Noever , "Michael S . Tsirkin" , Michael Jamet , "Rafael J . Wysocki" , Mika Westerberg , Jonathan Corbet , Jason Wang , Andi Kleen , Kuppuswamy Sathyanarayanan , LKML , Linux PCI , USB list , virtualization@lists.linux-foundation.org References: <20210930010511.3387967-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20210930010511.3387967-2-sathyanarayanan.kuppuswamy@linux.intel.com> From: "Kuppuswamy, Sathyanarayanan" Message-ID: Date: Thu, 30 Sep 2021 12:50:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 9/30/21 12:04 PM, Dan Williams wrote: >>> That's why it was highlighted in the changelog. Hopefully a >>> Thunderbolt developer can confirm if it is a non-issue. >>> Documentation/ABI/testing/sysfs-bus-thunderbolt does not seem to >>> answer this question about whether authorized_show and >>> authorized_store need to be symmetric. >> Apparently, Bolt does read it [1] and cares about it [2]. > Ah, thank you! > > Yeah, looks like the conversion to bool was indeed too hopeful. > IIUC, the end result of value "2" in authorized sysfs is to just "authorize" or "de-authorize". In that case, can the user space driver adapt to this int->bool change? Just want to know the possibility. -- Sathyanarayanan Kuppuswamy Linux Kernel Developer