From: Logan Gunthorpe <logang@deltatee.com>
To: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>
Subject: Re: [PATCH 0/1] Fix bug resulting in double hpmemsize being assigned to MMIO window
Date: Thu, 7 Nov 2019 10:25:05 -0700 [thread overview]
Message-ID: <c7de4e19-377c-7b82-3afd-f0fe40dcc20f@deltatee.com> (raw)
In-Reply-To: <PS2P216MB075530CB1B7B099AAF9F42D580780@PS2P216MB0755.KORP216.PROD.OUTLOOK.COM>
On 2019-11-07 6:50 a.m., Nicholas Johnson wrote:
> I have split this patch off my main series, as I realised that it does
> not need to be part of that series.
>
> I have made some recent improvements to add assurance against it
> breaking existing behaviour. Instead of returning the first resource of
> the desired type regardless of it being assigned, now it goes through
> all of the resources and returns only those of type that are not
> assigned. Only then does it go through and return the first resource of
> desired type that is assigned. If none are found then it returns NULL as
> usual.
>
> I have made extensive changes to the patch notes, also.
>
> Logan Gunthorpe <logang@deltatee.com> has an alternative method of
> fixing this same bug. Please also consider his patch and accept
> whichever is best for Linux. All I care is that the bug be fixed.
Oh, yes, I haven't had time to follow up on this. My patch is here[1].
It has a bit more info in the commit message and is a bit less
intrusive. However, Nicholas's approach is more of a cleanup and may be
a bit cleaner going forward.
I also had another bug fix in that series I really need to find time to
update and resend. I'll try to do it in the next cycle.
Logan
[1]
https://lore.kernel.org/linux-pci/20190531171216.20532-2-logang@deltatee.com/
prev parent reply other threads:[~2019-11-07 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 13:50 [PATCH 0/1] Fix bug resulting in double hpmemsize being assigned to MMIO window Nicholas Johnson
2019-11-07 17:25 ` Logan Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7de4e19-377c-7b82-3afd-f0fe40dcc20f@deltatee.com \
--to=logang@deltatee.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=nicholas.johnson-opensource@outlook.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).