From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADF81C433EF for ; Mon, 11 Apr 2022 16:04:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348372AbiDKQGS (ORCPT ); Mon, 11 Apr 2022 12:06:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347950AbiDKQGR (ORCPT ); Mon, 11 Apr 2022 12:06:17 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F4802C4 for ; Mon, 11 Apr 2022 09:04:03 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndwWA-000055-BS; Mon, 11 Apr 2022 18:03:54 +0200 Message-ID: Subject: Re: [PATCH v3] PCI: imx6: Replace legacy gpio interface for gpiod interface From: Lucas Stach To: Francesco Dolcini , =?ISO-8859-1?Q?Ma=EDra?= Canal , Lorenzo Pieralisi Cc: hongxing.zhu@nxp.com, robh@kernel.org, bhelgaas@google.com, helgaas@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, linux-imx@nxp.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Mon, 11 Apr 2022 18:03:51 +0200 In-Reply-To: <20220411115926.GA20890@francesco-nb.int.toradex.com> References: <20220411115926.GA20890@francesco-nb.int.toradex.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pci@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Maíra, hi Lorenzo, Am Montag, dem 11.04.2022 um 13:59 +0200 schrieb Francesco Dolcini: > On Fri, Apr 08, 2022 at 11:46:32AM -0300, Maíra Canal wrote: > > On Fri, Apr 08, 2022 at 03:23:39PM +0100, Lorenzo Pieralisi wrote: > > > On Mon, Nov 01, 2021 at 10:03:11PM -0300, Maíra Canal wrote: > > > > Considering the current transition of the GPIO subsystem, remove all > > > > dependencies of the legacy GPIO interface (linux/gpio.h and linux > > > > /of_gpio.h) and replace it with the descriptor-based GPIO approach. > > > > > > > > Signed-off-by: Maíra Canal > > > > --- > > > > V1 -> V2: Rewrite commit log and subject line to match PCI subsystem standard > > > > V2 -> v3: Change gpiod_set_value_cansleep for gpiod_set_raw_value_cansleep > > > > --- > > > > drivers/pci/controller/dwc/pci-imx6.c | 30 +++++++++------------------ > > > > 1 file changed, 10 insertions(+), 20 deletions(-) > > > > > > Maira, Lucas, > > > > > > what's this patch status ? Please let me know. The patch looks fine to me now, however... > > > > Thank you for the feedback. Since I sent v3, I didn't get any feedback from the community. > > > > If you have any feedback, I would gladly work on it. > > Just for you to know that it will likely conflict with > 'PCI: imx6: Fix PERST# start-up sequence' [0] that is also still waiting > for some additional feedback. ... they do conflict and I guess the functional fix for the reset sequence should have priority over this cleanup. Maíra, may I ask you to respin your patch as soon as Francescos fix is in? I promise to not let it fall through the cracks again. Regards, Lucas