From: Randy Dunlap <rdunlap@infradead.org>
To: Daire McNamara <daire.mcnamara@microchip.com>,
lorenzo.pieralisi@arm.com, amurray@thegoodpenguin.co.uk,
bhelgaas@google.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH v5] PCI: Microchip: Add host driver for Microchip PCIe controller
Date: Thu, 19 Mar 2020 08:57:59 -0700 [thread overview]
Message-ID: <cb7ec107-5be4-b65c-f366-45fc695cad6b@infradead.org> (raw)
In-Reply-To: <20200319154917.GA1232@IRE-LT-TRAIN04.mchp-main.com>
On 3/19/20 8:49 AM, Daire McNamara wrote:
> Signed-off-by: Daire McNamara <daire.mcnamara@microchip.com>
> --
> This v5 patch series adds support for PCIe IP block on Microchip PolarFire SoC.
>
> Updates since v4:
> * Fix compile issues
>
> Updates since v3:
> * Update all references to Microsemi to Microchip
> * Separate MSI functionality from legacy PCIe interrupt handling functionality
>
> Updates since v2:
> * Split out DT bindings and Vendor ID updates into their own patch
> from PCIe driver.
> * Updated Change Log
>
> Updates since v1:
> * Incorporate feedback from Bjorn Helgaas
>
>
> Daire McNamara (1):
> PCI: microchip: Add host driver for Microchip PCIe controller
>
> .../bindings/pci/microchip-pcie.txt | 64 ++
> drivers/pci/controller/Kconfig | 7 +
> drivers/pci/controller/Makefile | 1 +
> drivers/pci/controller/pcie-microchip.c | 789 ++++++++++++++++++
> 4 files changed, 861 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pci/microchip-pcie.txt
> create mode 100644 drivers/pci/controller/pcie-microchip.c
>
Hi,
Is the Kconfig symbol "PC" below a typo?
diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
index 6671946dbf66..7141d26e668c 100644
--- a/drivers/pci/controller/Kconfig
+++ b/drivers/pci/controller/Kconfig
@@ -280,5 +280,15 @@ config VMD
To compile this driver as a module, choose M here: the
module will be called vmd.
+config PCIE_MICROCHIP
+ bool "Microchip AXI PCIe host bridge support"
+ depends on PCI_MSI && OF
+ select PCI_MSI_IRQ_DOMAIN
+ select GENERIC_MSI_IRQ_DOMAIN
+ select PC <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
+ help
+ Say Y here if you want kernel to support the Microchip AXI PCIe
+ Host Bridge driver.
+
--
~Randy
next prev parent reply other threads:[~2020-03-19 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 15:49 [PATCH v5] PCI: Microchip: Add host driver for Microchip PCIe controller Daire McNamara
2020-03-19 15:57 ` Randy Dunlap [this message]
2020-03-20 7:04 ` Christoph Hellwig
2020-03-20 14:48 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7ec107-5be4-b65c-f366-45fc695cad6b@infradead.org \
--to=rdunlap@infradead.org \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bhelgaas@google.com \
--cc=daire.mcnamara@microchip.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).