From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23B04C4321E for ; Thu, 24 Feb 2022 08:43:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232060AbiBXIoC (ORCPT ); Thu, 24 Feb 2022 03:44:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231844AbiBXIn7 (ORCPT ); Thu, 24 Feb 2022 03:43:59 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0C4A583A0 for ; Thu, 24 Feb 2022 00:43:30 -0800 (PST) Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 56FC13FCA8 for ; Thu, 24 Feb 2022 08:43:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645692209; bh=Dcj0D0zPsXPEVS1eNhpQqfPztDcGavIHA1/tOM5ybJI=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=HFh0Y9pMIxRq5ATVBhCxUCMvCBmhEuT2J1x8IA9I1hRcjfUFLJ+cp597KAp3zOUgP vRdOdBgcQGCVReH3DKjSyI1TxGo6mx2HfG8N4sC5HODgarLKzu3Wos/G3VZDtLSPeA FNC5P1gUeGiNC6KLcbXbhCAij1ZHvsIY9yuDV0Ph35VJivEt5nyaSbg16QMVceq8KI 0rWfD9Nkq9OZQn266uM2aehGeEXjL8hV6UFTjDEBNUY3lKF3KrKUzeb2hTFUqA5OG6 CN3stpeR857YSdEBEByLaqX/uLvw3zx0kYBw+bc7j+24CL+n3xL/n2xmFCnkiETQ3e GJZbmVLuJvbgQ== Received: by mail-lf1-f71.google.com with SMTP id z37-20020a0565120c2500b004433b7d95d3so166257lfu.4 for ; Thu, 24 Feb 2022 00:43:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=Dcj0D0zPsXPEVS1eNhpQqfPztDcGavIHA1/tOM5ybJI=; b=Fu8ExYAkI/9ZSd1vBzZdzQ2hsfjnuV0EUFVpxkEjth3gCJx/b2e6uyyN8FheDyokbJ STeZhqDIJRZqwFScxK1JS5d2Ay0xi8E9OIgkOvtkTvtAtdPd8s5Q9b+WNhpO9sCPrkZ1 AQGuy1FW5Eag0Z5s4zI5b++KnGs0sLe/TSLhPRHtBtbQ59KovKUvCj5zMELPgxS1W5YJ IRMgTRPhbIxGBsJj7DPC76Bhv1XDlx4CU3vHwvdr8EkzrEudgyu2lWUszlfYdniJR59n FsbMSsYL7xi8lat3gc3367UCPBfRMMP9RzVhACkxGqFKC5eCu920o/j46rtinIZ1WWns Oyvw== X-Gm-Message-State: AOAM533vQ7Kvz2gf95CTLVVgPs2J5rvvNg7ftoyNwTY5ENkngGWBDSNd 7jeh1X78lPMWMrlosZIqqfl1iE3vbR6dFhlgdhP/ujcqxIsWahMIfhD4nLIkwBIWun36tHndd6N e4aEly3R5qNVuJ3wTkHWbEnrXOu7rNWvT1E5rfA== X-Received: by 2002:a05:6402:2744:b0:404:ba60:fec6 with SMTP id z4-20020a056402274400b00404ba60fec6mr1261652edd.235.1645692198573; Thu, 24 Feb 2022 00:43:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJyR9ltyboSTjtHA8dcoqW8jhNMCdSS02AQooqb5CLRWmWM576orT/UQwLqy77zZSpmBsHCJBQ== X-Received: by 2002:a05:6402:2744:b0:404:ba60:fec6 with SMTP id z4-20020a056402274400b00404ba60fec6mr1261610edd.235.1645692198343; Thu, 24 Feb 2022 00:43:18 -0800 (PST) Received: from [192.168.0.127] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id 16sm1006988eji.94.2022.02.24.00.43.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Feb 2022 00:43:17 -0800 (PST) Message-ID: Date: Thu, 24 Feb 2022 09:43:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 01/11] driver: platform: add and use helper for safer setting of driver_override Content-Language: en-US From: Krzysztof Kozlowski To: Bjorn Helgaas Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Stuart Yoder , Laurentiu Tudor , Abel Vesa , Shawn Guo , Sascha Hauer , Fabio Estevam , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , Srinivas Kandagatla , Mark Brown , "Michael S. Tsirkin" , Jason Wang , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds , Rasmus Villemoes References: <20220223215342.GA155282@bhelgaas> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 24/02/2022 08:47, Krzysztof Kozlowski wrote: > On 23/02/2022 22:53, Bjorn Helgaas wrote: >> On Wed, Feb 23, 2022 at 08:13:00PM +0100, Krzysztof Kozlowski wrote: >>> Several core drivers and buses expect that driver_override is a >>> dynamically allocated memory thus later they can kfree() it. >>> ... >> >>> + * set_driver_override() - Helper to set or clear driver override. >> >> Doesn't match actual function name. > > Good point. I wonder why build W=1 did not complain... I need to check. > I see why - I missed kerneldoc /** opener. Best regards, Krzysztof