From: Heiner Kallweit <hkallweit1@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts
Date: Mon, 30 Jul 2018 00:03:42 +0200 [thread overview]
Message-ID: <d004975f-03a8-59f5-56ef-f4e1f8e12dfb@gmail.com> (raw)
If we have a threaded interrupt with the handler being NULL, then
request_threaded_irq() -> __setup_irq() will complain and bail out
if the IRQF_ONESHOT flag isn't set. Therefore check for the handler
being NULL and set IRQF_ONESHOT in this case.
This change is needed to migrate the mei_me driver to
pci_alloc_irq_vectors() and pci_request_irq().
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/pci/irq.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/irq.c b/drivers/pci/irq.c
index 2a808e10..a1de501a 100644
--- a/drivers/pci/irq.c
+++ b/drivers/pci/irq.c
@@ -86,13 +86,17 @@ int pci_request_irq(struct pci_dev *dev, unsigned int nr, irq_handler_t handler,
va_list ap;
int ret;
char *devname;
+ unsigned long irqflags = IRQF_SHARED;
+
+ if (!handler)
+ irqflags |= IRQF_ONESHOT;
va_start(ap, fmt);
devname = kvasprintf(GFP_KERNEL, fmt, ap);
va_end(ap);
ret = request_threaded_irq(pci_irq_vector(dev, nr), handler, thread_fn,
- IRQF_SHARED, devname, dev_id);
+ irqflags, devname, dev_id);
if (ret)
kfree(devname);
return ret;
--
2.18.0
next reply other threads:[~2018-07-29 23:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-29 22:03 Heiner Kallweit [this message]
2018-07-30 21:30 ` [PATCH] PCI: let pci_request_irq properly deal with threaded interrupts Bjorn Helgaas
2018-07-30 21:50 ` Heiner Kallweit
2018-07-30 21:54 ` Andy Shevchenko
2018-07-30 22:36 ` Thomas Gleixner
2018-07-31 6:15 ` Marc Zyngier
2018-08-01 19:51 ` Heiner Kallweit
2018-08-03 14:09 ` Thomas Gleixner
2018-08-03 19:25 ` Heiner Kallweit
2018-08-03 19:40 ` Thomas Gleixner
2018-08-03 20:55 ` Heiner Kallweit
2018-07-30 22:42 ` Bjorn Helgaas
2018-07-30 22:50 ` Thomas Gleixner
2018-07-31 7:29 ` Lee Jones
2018-07-31 8:01 ` Russell King - ARM Linux
2018-07-31 11:13 ` Bjorn Helgaas
2018-07-31 8:08 ` Krzysztof Kozlowski
2018-07-30 23:05 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d004975f-03a8-59f5-56ef-f4e1f8e12dfb@gmail.com \
--to=hkallweit1@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).