From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 553B3C47428 for ; Tue, 6 Oct 2020 08:25:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12F252078E for ; Tue, 6 Oct 2020 08:25:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qHporHfA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726683AbgJFIZU (ORCPT ); Tue, 6 Oct 2020 04:25:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbgJFIZN (ORCPT ); Tue, 6 Oct 2020 04:25:13 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8262EC0613D1 for ; Tue, 6 Oct 2020 01:25:11 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id m6so12440474wrn.0 for ; Tue, 06 Oct 2020 01:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YdhpNKlTW8M5AEVFobND3IcWnRcYsnTU1ylxUOoxLOQ=; b=qHporHfANLglN4o1QtjGAQRWNnN7asjRL3cjazvXjsHh09RfWeLWPhNLVvwSLhWTRD dq9W25RBebcUYOBXWtFq8Xg4Jpr5iwt1eXNmqsekvon7Xl48K0UpprSPFSz88KD7f3X5 mVcgrKZ1Q+07rFYOZ6TaIw9SiDE9zLlxqZ10OzeIv3M1P2sRohlLAogcHVmvgwhtbxWh aDv0+4vxSuOdMGAP1BZwP0BlcnNmUE37U3q6XBhiOW2IywzQSNU0oPIf35dwBbDiZGem YyfEcoZuw1vq+eSTNb3BPCippk6TyfUXDjeg7Imo0qPxxzlaz4AKfZHvUV+rJldsOuzH 6yMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YdhpNKlTW8M5AEVFobND3IcWnRcYsnTU1ylxUOoxLOQ=; b=auqE8QgbTCPR5lcdrHy5fp2z0ssLSTX+zaBQ0wiUl6xIwEwSIPk1HLEcIrbjfGBlyw S4ZJX9LylD0lVflHccBjhNtpXf2fLDyg+x9hDsyvVZe28ifNYEOQ1ny3qEk902fzdW4n MSJD0xyR9e+u+badKh917fQdDfXv/zPX98Gs54u7sUVWPcLPojmJLY2wvU6Ih1oSFvUT sZyNSqjQZVDmeuKhmDuPmRr+OOmg/egOADUqn1bQn+gsFTtvN3/DKWfQRHmmORhhA42J Z4pkxofinr7SstuUO4RxZ8z6Iz89HUBf/HpIRxLkCdaYb8r1hOsgTh+Tx0qCpXjtJGt7 mXGw== X-Gm-Message-State: AOAM532iYzou8rfuj9D861by0kQV4q6k99NfP1fILQFnMgRy6Tuytj9W Vi6ckQ+7UetIzX+9UpNWm6ElLQ== X-Google-Smtp-Source: ABdhPJxsjuEumsaEtaU67N9vbg2cBftfsc/wZW21wnFzsv2BjeMFHC1JmQFLaFRJtrvHxARri2Z8Zg== X-Received: by 2002:a5d:6409:: with SMTP id z9mr120080wru.391.1601972710164; Tue, 06 Oct 2020 01:25:10 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id y11sm3353486wrs.16.2020.10.06.01.25.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Oct 2020 01:25:09 -0700 (PDT) Subject: Re: [PATCH 0/4] dt-bindings: additional/unevaluatedProperties clean-ups To: Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Albert Ou , Alessandro Zummo , Andrew Lunn , Bjorn Helgaas , Chanwoo Choi , Daniel Lezcano , "David S. Miller" , dmaengine@vger.kernel.org, Dmitry Torokhov , dri-devel@lists.freedesktop.org, Greg Kroah-Hartman , Heiner Kallweit , Jakub Kicinski , Jason Cooper , Jens Axboe , Jonathan Cameron , Krzysztof Kozlowski , Lars-Peter Clausen , Laurent Pinchart , Lee Jones , Liam Girdwood , Linus Walleij , Marc Kleine-Budde , Marc Zyngier , Mark Brown , Mathieu Poirier , Mauro Carvalho Chehab , Miquel Raynal , MyungJoo Ham , Palmer Dabbelt , Paul Walmsley , Pavel Machek , Peter Meerwald-Stadler , Richard Weinberger , Sam Ravnborg , Sebastian Reichel , Stephen Boyd , Thierry Reding , Thomas Bogendoerfer , Thomas Gleixner , Ulf Hansson , Vignesh Raghavendra , Vinod Koul , Viresh Kumar , Vivien Didelot , Wim Van Sebroeck , Wolfgang Grandegger , Zhang Rui , linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-i2c@vger.kernel.org, linux-ide@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org References: <20201005183830.486085-1-robh@kernel.org> From: Srinivas Kandagatla Message-ID: Date: Tue, 6 Oct 2020 09:25:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20201005183830.486085-1-robh@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 05/10/2020 19:38, Rob Herring wrote: > The default behavior for json-schema is any unknown property is allowed. > T > > hat is generally not the behavior we want for DT. In order to disallow > extra properties, schemas need to define 'additionalProperties: false' > typically. Ideally, we'd just add that automatically with the tools, but > there are some exceptions so only making things explicit everywhere > really works. Missing 'additionalProperties' or 'unevaluatedProperties' > has been a constant source of review comments, so a meta-schema check is > really needed here. > > Documentation/devicetree/bindings/nvmem/nvmem.yaml | 2 ++ > .../devicetree/bindings/nvmem/qcom,qfprom.yaml | 2 ++ for nvmem parts, Acked-by: Srinivas Kandagatla thanks, --srini