From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1FE5C433F5 for ; Thu, 12 May 2022 06:24:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350301AbiELGYP (ORCPT ); Thu, 12 May 2022 02:24:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350300AbiELGYG (ORCPT ); Thu, 12 May 2022 02:24:06 -0400 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [IPv6:2a01:488:42:1000:50ed:8234::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 801485A5A0 for ; Wed, 11 May 2022 23:24:05 -0700 (PDT) Received: from [2a02:8108:963f:de38:eca4:7d19:f9a2:22c5]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1np2F0-0003ty-1P; Thu, 12 May 2022 08:24:02 +0200 Message-ID: Date: Thu, 12 May 2022 08:24:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Bjorn Helgaas , Jim Quinlan Cc: Lorenzo Pieralisi , Cyril Brulebois , Nicolas Saenz Julienne , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org, regressions@lists.linux.dev, Bjorn Helgaas References: <20220511201856.808690-1-helgaas@kernel.org> <20220511201856.808690-2-helgaas@kernel.org> From: Thorsten Leemhuis Subject: Re: [PATCH 1/4] Revert "PCI: brcmstb: Do not turn off WOL regulators on suspend" In-Reply-To: <20220511201856.808690-2-helgaas@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1652336645;129144b5; X-HE-SMSGID: 1np2F0-0003ty-1P Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 11.05.22 22:18, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > This reverts commit 11ed8b8624b8085f706864b4addcd304b1e4fc38. > > This is part of a revert of the following commits: > > 11ed8b8624b8 ("PCI: brcmstb: Do not turn off WOL regulators on suspend") > 93e41f3fca3d ("PCI: brcmstb: Add control of subdevice voltage regulators") > 67211aadcb4b ("PCI: brcmstb: Add mechanism to turn on subdev regulators") > 830aa6f29f07 ("PCI: brcmstb: Split brcm_pcie_setup() into two funcs") > > Cyril reported that 830aa6f29f07 ("PCI: brcmstb: Split brcm_pcie_setup() > into two funcs"), which appeared in v5.17-rc1, broke booting on the > Raspberry Pi Compute Module 4. Apparently 830aa6f29f07 panics with an > Asynchronous SError Interrupt, and after further commits here is a black > screen on HDMI and no output on the serial console. > > This does not seem to affect the Raspberry Pi 4 B. > > Reported-by: Cyril Brulebois > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215925 A "Bugzilla" tag? Why don't you just use a proper "Link:" tag, as explained by the documentation to use in this case (I clarified the docs recently with regards to this). Such inventions (some people use "References:", others "BugLink:" and there were a few others I already forget about) make my regression tracking efforts hard. :-/ Side note: Linus in the past few days two times reminded people to use proper Link: tags, but that was in a totally different context (when there was no link at all or just a Link: pointing to the submission of a patch) > Signed-off-by: Bjorn Helgaas > [...] Ciao, Thorsten