From: "Chocron, Jonathan" <jonnyc@amazon.com>
To: "robh@kernel.org" <robh@kernel.org>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"Jisheng.Zhang@synaptics.com" <Jisheng.Zhang@synaptics.com>,
"gustavo.pimentel@synopsys.com" <gustavo.pimentel@synopsys.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH dwc-next v2 2/2] PCI: dwc: al: Remove useless dw_pcie_ops
Date: Mon, 25 Jan 2021 20:57:42 +0000 [thread overview]
Message-ID: <d9df69aa9373451f6ccb8884f72eda2623343168.camel@amazon.com> (raw)
In-Reply-To: <20201120191720.5a2320cf@xhacker.debian>
On Fri, 2020-11-20 at 19:17 +0800, Jisheng Zhang wrote:
> CAUTION: This email originated from outside of the organization. Do
> not click links or open attachments unless you can confirm the sender
> and know the content is safe.
>
>
>
> We have removed the dw_pcie_ops always exists assumption in dwc
> core driver, we can remove the useless dw_pcie_ops now.
>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> ---
> drivers/pci/controller/dwc/pcie-al.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-al.c
> b/drivers/pci/controller/dwc/pcie-al.c
> index 7ac8a37d9ce0..36977c48a7ae 100644
> --- a/drivers/pci/controller/dwc/pcie-al.c
> +++ b/drivers/pci/controller/dwc/pcie-al.c
> @@ -322,9 +322,6 @@ static const struct dw_pcie_host_ops
> al_pcie_host_ops = {
> .host_init = al_pcie_host_init,
> };
>
> -static const struct dw_pcie_ops dw_pcie_ops = {
> -};
> -
> static int al_pcie_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> @@ -342,7 +339,6 @@ static int al_pcie_probe(struct platform_device
> *pdev)
> return -ENOMEM;
>
> pci->dev = dev;
> - pci->ops = &dw_pcie_ops;
> pci->pp.ops = &al_pcie_host_ops;
>
> al_pcie->pci = pci;
> --
> 2.29.2
>
Acked-by: Jonathan Chocron <jonnyc@amazon.com>
Thanks,
Jonathan
next prev parent reply other threads:[~2021-01-25 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 11:16 [PATCH dwc-next v2 0/2] PCI: dwc: remove useless dw_pcie_ops Jisheng Zhang
2020-11-20 11:17 ` [PATCH dwc-next v2 2/2] PCI: dwc: al: Remove " Jisheng Zhang
2021-01-25 20:57 ` Chocron, Jonathan [this message]
2020-11-20 11:17 ` [PATCH dwc-next v2 1/2] PCI: dwc: Don't assume the ops in dw_pcie always exists Jisheng Zhang
2021-01-25 16:25 ` [PATCH dwc-next v2 0/2] PCI: dwc: remove useless dw_pcie_ops Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9df69aa9373451f6ccb8884f72eda2623343168.camel@amazon.com \
--to=jonnyc@amazon.com \
--cc=Jisheng.Zhang@synaptics.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).