From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com ([209.85.128.196]:45775 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752569AbeEUNME (ORCPT ); Mon, 21 May 2018 09:12:04 -0400 Subject: Re: [PATCH V5] PCI: rcar: Use runtime PM to control controller clock To: Lorenzo Pieralisi Cc: Simon Horman , Geert Uytterhoeven , linux-pci , Dien Pham , Hien Dang , Marek Vasut , Geert Uytterhoeven , Phil Edworthy , Wolfram Sang , Linux-Renesas References: <20180413124819.tw5436lolpn5eqhw@verge.net.au> <20180501105556.GB19391@e107981-ln.cambridge.arm.com> <20180514154909.GB13324@e107981-ln.cambridge.arm.com> <20180521130303.GA1443@e107981-ln.cambridge.arm.com> From: Marek Vasut Message-ID: Date: Mon, 21 May 2018 15:09:54 +0200 MIME-Version: 1.0 In-Reply-To: <20180521130303.GA1443@e107981-ln.cambridge.arm.com> Content-Type: text/plain; charset=utf-8 Sender: linux-pci-owner@vger.kernel.org List-ID: On 05/21/2018 03:03 PM, Lorenzo Pieralisi wrote: > On Mon, May 21, 2018 at 01:08:36PM +0200, Marek Vasut wrote: >> On 05/14/2018 05:49 PM, Lorenzo Pieralisi wrote: >>> On Mon, May 14, 2018 at 05:32:04PM +0200, Marek Vasut wrote: >>>> On 05/01/2018 12:55 PM, Lorenzo Pieralisi wrote: >>>>> On Fri, Apr 13, 2018 at 02:48:19PM +0200, Simon Horman wrote: >>>>>> On Tue, Apr 10, 2018 at 06:17:04PM +0200, Marek Vasut wrote: >>>>>>> On 04/10/2018 05:28 PM, Geert Uytterhoeven wrote: >>>>>> >>>>>> ... >>>>>> >>>>>>>>>> rcar_pcie_get_resources() is called while the device is >>>>>>>>>> runtime-enabled/resumed, >>>>>>>>>> pci_free_resource_list() is called while the device is runtime-disabled. >>>>>>> >>>>>>> rcar_pcie_get_resources() is NOT a pair function for >>>>>>> pci_free_resource_list() . rcar_pcie_parse_request_of_pci_ranges() is a >>>>>>> pair function for pci_free_resource_list(). >>>>>>> >>>>>>> rcar_pcie_parse_request_of_pci_ranges() calls >>>>>>> of_pci_get_host_bridge_resources() internally, so every single function >>>>>>> called after successful call of rcar_pcie_parse_request_of_pci_ranges() >>>>>>> must call pci_free_resource_list(). >>>>>>> >>>>>>> Both of_pci_get_host_bridge_resources() and pci_free_resource_list() are >>>>>>> called with runtime PM disabled. >>>>>>> >>>>>>> The naming of the functions is confusing though. >>>>>> >>>>>> Hi, >>>>>> >>>>>> thanks everyone for their efforts in preparing/reviewing this patch. >>>>>> >>>>>> It seems there are some differences of opinion on how best to handle the >>>>>> error paths but unlike earlier versions this one seems correct to me. If >>>>>> that turns out to be false we can address it. But I don't think its likely >>>>>> things will be enhanced by continuing this review. >>>>>> >>>>>> Lorenzo, please consider taking this patch in its current form. >>>>>> >>>>>> Reviewed-by: Simon Horman >>>>> >>>>> Applied to pci/rcar for v4.18, thanks. >>>> >>>> Is there any reason why this patch isnt in next yet ? >>> >>> Bjorn will merge it into -next this week. >> >> Seems this got missed last week ? > > It will go into -next as soon as a new -next release will > be available: > > https://marc.info/?l=linux-next&m=152654084627146&w=2 Cool, thanks, I have a few more fixes coming. -- Best regards, Marek Vasut