From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7733C8301D for ; Mon, 30 Nov 2020 13:38:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76B09206F9 for ; Mon, 30 Nov 2020 13:38:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AqQRbYB0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727358AbgK3NiK (ORCPT ); Mon, 30 Nov 2020 08:38:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25788 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727330AbgK3NiJ (ORCPT ); Mon, 30 Nov 2020 08:38:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606743403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q9JbBB2A7RKXT6r+Tdc668k94iLZr4WU1zIyHLKBU0Y=; b=AqQRbYB0CRrMLri7hlaJcOewbFZ74+QgGzJ7bCFCYVt+NeyGnkv4/fMa5tiGJ8O2hHnhzJ ySxE4uJkLdYwQ9Os+auI7huva1rJz57Hbvzg1O+0OXR9vzqMVkx9p7TCNfeFklef+o9pf1 LzZmLssr90pT2vVnngPG6MYMpLuwXyg= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-443-qbS42CxaPpS4k7aqvsJSIQ-1; Mon, 30 Nov 2020 08:36:41 -0500 X-MC-Unique: qbS42CxaPpS4k7aqvsJSIQ-1 Received: by mail-ej1-f69.google.com with SMTP id t17so2831191ejd.12 for ; Mon, 30 Nov 2020 05:36:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=q9JbBB2A7RKXT6r+Tdc668k94iLZr4WU1zIyHLKBU0Y=; b=Vhl+0u83xjDlZPrVXsxeK1MbcItLweA1EWkHrZ+s/Uhs0wQn4aV9MP6l+XqvUg5Yce 8e1nzvUHhyqlZq49po1iGDNS1MhNuqQfmX+CMnGPRcUbQYgWrimIB8g3KA0RNXmGjc6E zUfEbGrJZg2YQw4F+9xvvabMS3AQnaji1yObfdLkaSTb9bJ7GaXVvcxed6UL5/yxARlF qFWQ7C9cTOzjt71zJvODRoqHDdquFfkORXbv0ZAAjAK7Ot0DsvhDmiXgfW1HV42rUINP ol0p1j0cCNunawNrvf9JIKEPv0Cp8dJtr/puH8FO7BSU26h7Q/u6Ljytyz6tpmHJyjel gJOQ== X-Gm-Message-State: AOAM532vOGLYo5sCGCUbVPySr9tCvEGWKhtMKh7Sl7itHZad3p/LSkM1 +rPWtD8CNtlcAubdq7RwwXexFk2+OemOwxTvGtTqi07k4v33033CAX/xhgp3vy0WxrPV50jv17a 1AJ1Qq+0gkEKGei+0q/6v X-Received: by 2002:a17:906:5609:: with SMTP id f9mr8831125ejq.535.1606743399841; Mon, 30 Nov 2020 05:36:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5mfLtnxz7qBhLC9okDROTxfIFdoHVpU+wO1LzztHlLZ97RDP+W+0qNE61l1UYE22GzJnORQ== X-Received: by 2002:a17:906:5609:: with SMTP id f9mr8831103ejq.535.1606743399647; Mon, 30 Nov 2020 05:36:39 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id a12sm9009835edu.89.2020.11.30.05.36.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Nov 2020 05:36:38 -0800 (PST) Subject: Re: [PATCH 2/2] usb-storage: revert from scsi_add_host_with_dma() to scsi_add_host() To: Greg KH Cc: Tom Yan , Alan Stern , Christoph Hellwig , linux-usb , Mathias Nyman , Linux Kernel Mailing List , linux-pci@vger.kernel.org, Lu Baolu References: <09992cec-65e4-2757-aae6-8fb02a42f961@redhat.com> <20201128154849.3193-1-tom.ty89@gmail.com> <20201128154849.3193-2-tom.ty89@gmail.com> <5e62c383-22ea-6df6-5acc-5e9f381d4632@redhat.com> <186eb035-4bc4-ff72-ee41-aeb6d81888e3@redhat.com> From: Hans de Goede Message-ID: Date: Mon, 30 Nov 2020 14:36:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi, On 11/30/20 2:30 PM, Greg KH wrote: > On Mon, Nov 30, 2020 at 02:23:48PM +0100, Hans de Goede wrote: >> Hi, >> >> On 11/30/20 1:58 PM, Tom Yan wrote: >>> It's merely a moving of comment moving for/and a no-behavioral-change >>> adaptation for the reversion.> >> >> IMHO the revert of the troublesome commit and the other/new changes really >> should be 2 separate commits. But I will let Alan and Greg have the final >> verdict on this. > > I would prefer to just revert the commits and not do anything > different/special here so late in the release cycle. > > So, if Alan agrees, I'll be glad to do them on my end, I just need the > commit ids for them. The troublesome commit are (in reverse, so revert, order): 5df7ef7d32fe ("uas: bump hw_max_sectors to 2048 blocks for SS or faster drives") 558033c2828f ("uas: fix sdev->host->dma_dev") 0154012f8018 ("usb-storage: fix sdev->host->dma_dev") Alan, the reason for reverting these is that using scsi_add_host_with_dma() as the last 2 patches do, with the dmadev argument of that call pointing to the device for the XHCI controller is causing changes to the DMA settings of the XHCI controller itself which is causing regressions in 5.10, see this email thread: https://lore.kernel.org/linux-usb/fde7e11f-5dfc-8348-c134-a21cb1116285@redhat.com/T/#t Regards, Hans