From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH 3/9] PCI: pciehp: Drop hotplug_slot_ops wrappers To: Lukas Wunner , Bjorn Helgaas , linux-pci@vger.kernel.org, Mika Westerberg References: From: Sinan Kaya Message-ID: Date: Sun, 19 Aug 2018 18:01:04 -0400 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed List-ID: On 8/19/2018 10:29 AM, Lukas Wunner wrote: > pciehp's ->enable_slot, ->disable_slot, ->get_attention_status and > ->reset_slot callbacks are currently implemented by wrapper functions > that do nothing else but call down to a backend function. The backends > are not called from anywhere else, so drop the wrappers and use the > backends directly as callbacks, thereby shaving off a few lines of > unnecessary code. > > No functional change intended. > > Signed-off-by: Lukas Wunner Great work. I was surprised by the number of steps we need to jump in order to reach to real code here. Simplification is welcome.