From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Richard Zhu <hongxing.zhu@nxp.com>,
Lucas Stach <l.stach@pengutronix.de>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] PCI: imx6: Use fallthrough pseudo-keyword
Date: Tue, 21 Jul 2020 22:22:52 -0500 [thread overview]
Message-ID: <e20b7b95-4b61-4ade-cf90-40f49f3744bf@embeddedor.com> (raw)
In-Reply-To: <20200716220629.GA663054@bjorn-Precision-5520>
Hi Bjorn,
On 7/16/20 17:06, Bjorn Helgaas wrote:
> On Thu, Jul 16, 2020 at 04:10:52PM -0500, Gustavo A. R. Silva wrote:
>> Replace the existing /* fall through */ comments and its variants with
>> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
>> fall-through markings when it is the case.
>>
>> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> Hi Gustavo,
>
> I'm certainly fine with these patches, and thanks for doing them!
>
> And thanks for providing a link to the rationale. But the URL
> contains "latest", so I think it may break if deprecated.rst or the
> section is ever renamed.
>
> I think I would prefer if we could reference the current text, e.g.,
> via
>
> https://www.kernel.org/doc/html/v5.7-rc7/process/deprecated.html#implicit-switch-case-fall-through
>
I already sent v2 with a URL to proper documentation for Linux v5.7:
https://lore.kernel.org/lkml/20200722031903.GA3711@embeddedor/
> (The v5.7 doc would be better but doesn't seem to be generated yet; I
> pinged the helpdesk about that.)
>
Thanks for doing that. I wasn't aware that one could ask helpdesk about this.
--
Gustavo
prev parent reply other threads:[~2020-07-22 3:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 21:10 [PATCH][next] PCI: imx6: Use fallthrough pseudo-keyword Gustavo A. R. Silva
2020-07-16 22:06 ` Bjorn Helgaas
2020-07-22 3:22 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e20b7b95-4b61-4ade-cf90-40f49f3744bf@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=bhelgaas@google.com \
--cc=festevam@gmail.com \
--cc=gustavoars@kernel.org \
--cc=helgaas@kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).