From: Vidya Sagar <vidyas@nvidia.com>
To: Kishon Vijay Abraham I <kishon@ti.com>, <jingoohan1@gmail.com>,
<gustavo.pimentel@synopsys.com>, <lorenzo.pieralisi@arm.com>,
<bhelgaas@google.com>, <Jisheng.Zhang@synaptics.com>,
<thierry.reding@gmail.com>
Cc: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kthota@nvidia.com>, <mmaddireddy@nvidia.com>,
<sagar.tv@gmail.com>
Subject: Re: [PATCH V5 2/3] PCI: dwc: Cleanup DBI read and write APIs
Date: Fri, 21 Jun 2019 15:17:01 +0530 [thread overview]
Message-ID: <e23ef76b-e74a-ee29-05c2-5c09f206ee36@nvidia.com> (raw)
In-Reply-To: <63b59d6b-f6d7-fe4f-f319-6459a146ef36@ti.com>
On 6/21/2019 2:57 PM, Kishon Vijay Abraham I wrote:
> Hi Vidya,
>
> On 21/06/19 2:51 PM, Vidya Sagar wrote:
>> Cleanup DBI read and write APIs by removing "__" (underscore) from their
>> names as there are no no-underscore versions and the underscore versions
>> are already doing what no-underscore versions typically do.
>>
>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>> ---
>> Changes from v4:
>> * This is a new patch in this series
>>
>> drivers/pci/controller/dwc/pcie-designware.c | 16 ++++-----
>> drivers/pci/controller/dwc/pcie-designware.h | 36 ++++++++++----------
>> 2 files changed, 26 insertions(+), 26 deletions(-)
>>
>> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
>> index 9d7c51c32b3b..5d22028d854e 100644
>> --- a/drivers/pci/controller/dwc/pcie-designware.c
>> +++ b/drivers/pci/controller/dwc/pcie-designware.c
>> @@ -52,8 +52,8 @@ int dw_pcie_write(void __iomem *addr, int size, u32 val)
>> return PCIBIOS_SUCCESSFUL;
>> }
>>
>> -u32 __dw_pcie_read_dbi(struct dw_pcie *pci, void __iomem *base, u32 reg,
>> - size_t size)
>> +u32 dw_pcie_read_dbi(struct dw_pcie *pci, void __iomem *base, u32 reg,
>> + size_t size)
>
> The "base" here was added when we used the same API for both dbi_base and
> dbi_base2. Now that we have separate APIs, we should be able to remove that.
>
> Thanks
> Kishon
>
Got it. Let me address it.
next prev parent reply other threads:[~2019-06-21 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 9:21 [PATCH V5 1/3] PCI: dwc: Add API support to de-initialize host Vidya Sagar
2019-06-21 9:21 ` [PATCH V5 2/3] PCI: dwc: Cleanup DBI read and write APIs Vidya Sagar
2019-06-21 9:27 ` Kishon Vijay Abraham I
2019-06-21 9:47 ` Vidya Sagar [this message]
2019-06-21 9:21 ` [PATCH V5 3/3] PCI: dwc: Export APIs to support .remove() implementation Vidya Sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e23ef76b-e74a-ee29-05c2-5c09f206ee36@nvidia.com \
--to=vidyas@nvidia.com \
--cc=Jisheng.Zhang@synaptics.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@ti.com \
--cc=kthota@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mmaddireddy@nvidia.com \
--cc=sagar.tv@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).