* [PATCH] ntb_hw_switchtec: potential shift wrapping bug in switchtec_ntb_init_sndev()
@ 2019-03-25 9:17 Dan Carpenter
2019-03-25 15:49 ` Logan Gunthorpe
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2019-03-25 9:17 UTC (permalink / raw)
To: Kurt Schwemmer, Kelvin Cao
Cc: Logan Gunthorpe, Jon Mason, Dave Jiang, Allen Hubbe, linux-pci,
linux-ntb, kernel-janitors
This code triggers a Smatch warning:
drivers/ntb/hw/mscc/ntb_hw_switchtec.c:884 switchtec_ntb_init_sndev()
warn: should '(1 << sndev->peer_partition)' be a 64 bit type?
The "part_map" and "tpart_vec" variables are u64 type so this seems like
a valid warning.
Fixes: 3df54c870f52 ("ntb_hw_switchtec: Allow using Switchtec NTB in multi-partition setups")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
index d905d368d28c..26a88731b0cb 100644
--- a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
+++ b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
@@ -881,7 +881,7 @@ static int switchtec_ntb_init_sndev(struct switchtec_ntb *sndev)
}
sndev->peer_partition = ffs(tpart_vec) - 1;
- if (!(part_map & (1 << sndev->peer_partition))) {
+ if (!(part_map & (1ULL << sndev->peer_partition))) {
dev_err(&sndev->stdev->dev,
"ntb target partition is not NT partition\n");
return -ENODEV;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ntb_hw_switchtec: potential shift wrapping bug in switchtec_ntb_init_sndev()
2019-03-25 9:17 [PATCH] ntb_hw_switchtec: potential shift wrapping bug in switchtec_ntb_init_sndev() Dan Carpenter
@ 2019-03-25 15:49 ` Logan Gunthorpe
2019-06-13 13:25 ` Jon Mason
0 siblings, 1 reply; 3+ messages in thread
From: Logan Gunthorpe @ 2019-03-25 15:49 UTC (permalink / raw)
To: Dan Carpenter, Kurt Schwemmer, Kelvin Cao
Cc: Jon Mason, Dave Jiang, Allen Hubbe, linux-pci, linux-ntb,
kernel-janitors
Thanks!
On 2019-03-25 3:17 a.m., Dan Carpenter wrote:
> This code triggers a Smatch warning:
>
> drivers/ntb/hw/mscc/ntb_hw_switchtec.c:884 switchtec_ntb_init_sndev()
> warn: should '(1 << sndev->peer_partition)' be a 64 bit type?
>
> The "part_map" and "tpart_vec" variables are u64 type so this seems like
> a valid warning.
>
> Fixes: 3df54c870f52 ("ntb_hw_switchtec: Allow using Switchtec NTB in multi-partition setups")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ntb_hw_switchtec: potential shift wrapping bug in switchtec_ntb_init_sndev()
2019-03-25 15:49 ` Logan Gunthorpe
@ 2019-06-13 13:25 ` Jon Mason
0 siblings, 0 replies; 3+ messages in thread
From: Jon Mason @ 2019-06-13 13:25 UTC (permalink / raw)
To: Logan Gunthorpe
Cc: Dan Carpenter, Kurt Schwemmer, Kelvin Cao, Dave Jiang,
Allen Hubbe, linux-pci, linux-ntb, kernel-janitors
On Mon, Mar 25, 2019 at 09:49:31AM -0600, Logan Gunthorpe wrote:
> Thanks!
>
> On 2019-03-25 3:17 a.m., Dan Carpenter wrote:
> > This code triggers a Smatch warning:
> >
> > drivers/ntb/hw/mscc/ntb_hw_switchtec.c:884 switchtec_ntb_init_sndev()
> > warn: should '(1 << sndev->peer_partition)' be a 64 bit type?
> >
> > The "part_map" and "tpart_vec" variables are u64 type so this seems like
> > a valid warning.
> >
> > Fixes: 3df54c870f52 ("ntb_hw_switchtec: Allow using Switchtec NTB in multi-partition setups")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Sorry for the delay. The patch is now in the ntb branch. We've
missed window for 5.2, but it will be in the 5.3 pull request.
Thanks,
Jon
>
> --
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@googlegroups.com.
> To post to this group, send email to linux-ntb@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/e2bc8cf0-8e3e-9335-e21b-4a9697e9c0ef%40deltatee.com.
> For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-13 15:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-25 9:17 [PATCH] ntb_hw_switchtec: potential shift wrapping bug in switchtec_ntb_init_sndev() Dan Carpenter
2019-03-25 15:49 ` Logan Gunthorpe
2019-06-13 13:25 ` Jon Mason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).