From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99D3FC2BBCF for ; Fri, 18 Dec 2020 06:48:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64F5A23A9B for ; Fri, 18 Dec 2020 06:48:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732787AbgLRGsm (ORCPT ); Fri, 18 Dec 2020 01:48:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732778AbgLRGsm (ORCPT ); Fri, 18 Dec 2020 01:48:42 -0500 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD9F0C0617B0 for ; Thu, 17 Dec 2020 22:48:01 -0800 (PST) Received: by mail-pl1-x635.google.com with SMTP id r4so878613pls.11 for ; Thu, 17 Dec 2020 22:48:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Nd22eKsSmk6waOLkekeVIJaN2h0vcQRGdExQuNh8r+o=; b=JV55w9RJHlNDrpbAs0KqCWm5jTeBirALv3OzEGNimJnmYPpOniRKISwjJZ99KwhMia LZ0cA/j4WGXRXImtf+x7TlBbmYI7cqTI/lNnoBocYvBqR78jTb5wkzTOE5fcLGIRCV54 IJwjhcuUOQH2w+I7lEdNtGIM9ry2apQPMX4YimceNtL7qwHnAb1BSx4GOpcpCrkVUcgE 8ItjJeUDB8wbN64mphSntnZpXnDtkrrdQKmSWbNcGYgUPqbPpb7IrGaaKwTg+PStjlIP LFy4K6txICy13Oly9GRbh2hxr0hNbKZ0STEFSLj1ymii+OWwgL6EI1gv9ZDgFpBEY8cM pSyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Nd22eKsSmk6waOLkekeVIJaN2h0vcQRGdExQuNh8r+o=; b=LTeT+ro7emJHVKP0hZze6JPNcGWoUEwG+cnVk+Toy4qLtAvlKrZxP6NincHygkZWYn tLpBi0lVVz90rfiugxfrPbNdKtITN/UP9cxh09XUg9fkA9PZkApipjXfxm1fxMoOH7Xj JCVi+dY4SCsUZoapXybqR+48fZboCrHBr4X568uCkGWRho6CEJdmvGo1A5Tit6SagWOC 8bi4se55SjJfThXgAuwSdvPqIz1mCERUnPz8UZGXopgEpglcXikMCtfMMTnAdwmSm4uq 0sbFjI2GZCIx15nBa3uD2A0EorzFjAJFyk+VnI+iogev5hTQay1qPH7lhA561iPorLiC U9mw== X-Gm-Message-State: AOAM530qkvgKrO3B+crebpka8DBDu43y38APYx8P7nOVnRvZoeTBEvmf vsxJIEHVfxTr4X13K2cIKQFxog== X-Google-Smtp-Source: ABdhPJxN+zyn/o5/ECghJrrBpTGxb9htIs8KNFZW3iJjEN2NNdnXvN4NN921DPcleas8TN59wDvxSg== X-Received: by 2002:a17:90a:fe8e:: with SMTP id co14mr2998599pjb.105.1608274081410; Thu, 17 Dec 2020 22:48:01 -0800 (PST) Received: from ?IPv6:240e:362:421:6800:e481:5ceb:8cc4:e9ab? ([240e:362:421:6800:e481:5ceb:8cc4:e9ab]) by smtp.gmail.com with ESMTPSA id j20sm7610772pfd.106.2020.12.17.22.47.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Dec 2020 22:48:00 -0800 (PST) Subject: Re: [PATCH v8 4/9] of/iommu: Support dma-can-stall property To: Jean-Philippe Brucker , Robin Murphy Cc: joro@8bytes.org, will@kernel.org, lorenzo.pieralisi@arm.com, robh+dt@kernel.org, guohanjun@huawei.com, sudeep.holla@arm.com, rjw@rjwysocki.net, lenb@kernel.org, bhelgaas@google.com, Jonathan.Cameron@huawei.com, eric.auger@redhat.com, iommu@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, baolu.lu@linux.intel.com, shameerali.kolothum.thodi@huawei.com, vivek.gautam@arm.com References: <20201112125519.3987595-1-jean-philippe@linaro.org> <20201112125519.3987595-5-jean-philippe@linaro.org> From: Zhangfei Gao Message-ID: Date: Fri, 18 Dec 2020 14:47:11 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 2020/12/14 下午8:51, Jean-Philippe Brucker wrote: > On Thu, Nov 26, 2020 at 06:09:26PM +0000, Robin Murphy wrote: >> On 2020-11-12 12:55, Jean-Philippe Brucker wrote: >>> Copy the dma-can-stall property into the fwspec structure. >> Can't we just handle this as a regular device property? It's not part of the >> actual IOMMU specifier, it doesn't need to be translated in any way, and >> AFAICS it's used a grand total of once, in a slow path. Simply treating it >> as the per-device property that it is should require zero additional code >> for DT, and a simple device_add_properties() call for IORT. >> >> TBH that appears to be true of pasid-num-bits as well. > Right I think that's better, thanks for the pointer. I'll take care of > pasid-num-bits too. The Huawei quirk (fake PCIe supporting stall) is a > little worse this way, but it should work. Thanks Jean, I tested the following diff, it works with Huawei quirk. Thanks