From: Zhuo Chen <chenzhuo.1@bytedance.com>
To: Serge Semin <fancer.lancer@gmail.com>,
bhelgaas@google.com,
Sathyanarayanan Kuppuswamy
<sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: ruscur@russell.cc, oohall@gmail.com, jdmason@kudzu.us,
dave.jiang@intel.com, allenbh@gmail.com,
james.smart@broadcom.com, dick.kennedy@broadcom.com,
jejb@linux.ibm.com, martin.petersen@oracle.com,
linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, ntb@lists.linux.dev,
linux-scsi@vger.kernel.org
Subject: Re: [External] Re: [PATCH v3 0/9] PCI/AER: Fix and optimize usage of status clearing api
Date: Wed, 28 Sep 2022 23:54:02 +0800 [thread overview]
Message-ID: <eade28ce-97eb-ff96-e8cb-7e1c2127f77b@bytedance.com> (raw)
In-Reply-To: <20220928110623.b3vocoubasrshyzk@mobilestation>
On 9/28/22 7:06 PM, Serge Semin wrote:
> On Wed, Sep 28, 2022 at 06:59:37PM +0800, Zhuo Chen wrote:
>> Hello.
>>
>> Here comes patch v3, which contains some fixes and optimizations of
>> aer api usage. The v1 and v2 can be found on the mailing list.
>>
>> v3:
>> - Modifications to comments proposed by Sathyanarayanan.
>
>> Remove
>> pci_aer_clear_nonfatal_status() call in NTB and improve commit log.
>
> Failed to see who has requested that...
>
> -Sergey
>
Hi, Sergey
Currently other vendor drivers do not clear error status in their own
init code, I don't exactly know what is special reason for clearing
error status during init code in ntb driver.
An evidence is in pci_aer_init(), PCI core driver has do
pci_aer_clear_status() and pci_enable_pcie_error_reporting() in common
process. So vendor drivers don't need to do again.
But I don't know the reason why many vendor drivers reserve
pci_enable_pcie_error_reporting() after commit f26e58bf6f54 ("PCI/AER:
Enable error reporting when AER is native"). Do they need to be removed?
Could Bjorn and Sathyanarayanan help look into it, thanks a lot.
Thanks.
>>
>> v2:
>> - Modifications to comments proposed by Bjorn. Split patch into more
>> obvious parts.
>>
>> Zhuo Chen (9):
>> PCI/AER: Add pci_aer_clear_uncorrect_error_status() to PCI core
>> PCI/DPC: Use pci_aer_clear_uncorrect_error_status() to clear
>> uncorrectable error status
>> NTB: Remove pci_aer_clear_nonfatal_status() call
>> scsi: lpfc: Change to use pci_aer_clear_uncorrect_error_status()
>> PCI/AER: Unexport pci_aer_clear_nonfatal_status()
>> PCI/AER: Move check inside pcie_clear_device_status().
>> PCI/AER: Use pcie_aer_is_native() to judge whether OS owns AER
>> PCI/ERR: Clear fatal error status when pci_channel_io_frozen
>> PCI/AER: Refine status clearing process with api
>>
>> drivers/ntb/hw/idt/ntb_hw_idt.c | 2 --
>> drivers/pci/pci.c | 7 +++--
>> drivers/pci/pci.h | 2 ++
>> drivers/pci/pcie/aer.c | 45 +++++++++++++++++++--------------
>> drivers/pci/pcie/dpc.c | 3 +--
>> drivers/pci/pcie/err.c | 15 ++++-------
>> drivers/pci/pcie/portdrv_core.c | 3 +--
>> drivers/scsi/lpfc/lpfc_attr.c | 4 +--
>> include/linux/aer.h | 4 +--
>> 9 files changed, 44 insertions(+), 41 deletions(-)
>>
>> --
>> 2.30.1 (Apple Git-130)
>>
--
Zhuo Chen
next prev parent reply other threads:[~2022-09-28 15:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 10:59 [PATCH v3 0/9] PCI/AER: Fix and optimize usage of status clearing api Zhuo Chen
2022-09-28 10:59 ` [PATCH v3 1/9] PCI/AER: Add pci_aer_clear_uncorrect_error_status() to PCI core Zhuo Chen
2023-03-15 21:29 ` Bjorn Helgaas
2022-09-28 10:59 ` [PATCH v3 2/9] PCI/DPC: Use pci_aer_clear_uncorrect_error_status() to clear uncorrectable error status Zhuo Chen
2022-09-28 10:59 ` [PATCH v3 3/9] NTB: Remove pci_aer_clear_nonfatal_status() call Zhuo Chen
2022-09-28 11:03 ` Serge Semin
2022-12-06 18:09 ` Bjorn Helgaas
2022-12-06 21:41 ` Serge Semin
2023-03-15 21:31 ` Bjorn Helgaas
2022-09-28 10:59 ` [PATCH v3 4/9] scsi: lpfc: Change to use pci_aer_clear_uncorrect_error_status() Zhuo Chen
2022-12-06 22:13 ` Bjorn Helgaas
2023-03-15 21:35 ` Bjorn Helgaas
2023-03-30 23:43 ` Justin Tee
2022-09-28 10:59 ` [PATCH v3 5/9] PCI/AER: Unexport pci_aer_clear_nonfatal_status() Zhuo Chen
2022-09-28 10:59 ` [PATCH v3 6/9] PCI/AER: Move check inside pcie_clear_device_status() Zhuo Chen
2022-09-28 10:59 ` [PATCH v3 7/9] PCI/AER: Use pcie_aer_is_native() to judge whether OS owns AER Zhuo Chen
2022-09-28 10:59 ` [PATCH v3 8/9] PCI/ERR: Clear fatal error status when pci_channel_io_frozen Zhuo Chen
2022-12-06 21:42 ` Bjorn Helgaas
2022-09-28 10:59 ` [PATCH v3 9/9] PCI/AER: Refine status clearing process with api Zhuo Chen
2022-09-28 11:06 ` [PATCH v3 0/9] PCI/AER: Fix and optimize usage of status clearing api Serge Semin
2022-09-28 15:54 ` Zhuo Chen [this message]
2022-11-04 17:20 ` Zhuo Chen
2022-11-24 11:55 ` Zhuo Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eade28ce-97eb-ff96-e8cb-7e1c2127f77b@bytedance.com \
--to=chenzhuo.1@bytedance.com \
--cc=allenbh@gmail.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=dick.kennedy@broadcom.com \
--cc=fancer.lancer@gmail.com \
--cc=james.smart@broadcom.com \
--cc=jdmason@kudzu.us \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.petersen@oracle.com \
--cc=ntb@lists.linux.dev \
--cc=oohall@gmail.com \
--cc=ruscur@russell.cc \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).