From: Pu Wen <puwen@hygon.cn>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, thomas.lendacky@amd.com, bp@alien8.de,
pbonzini@redhat.com, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 07/17] x86/pci: add Hygon PCI vendor and northbridge support
Date: Tue, 14 Aug 2018 12:56:51 +0800 [thread overview]
Message-ID: <ec0ef867-3254-9e17-bf37-de697e9d0709@hygon.cn> (raw)
In-Reply-To: <20180813221436.GN113140@bhelgaas-glaptop.roam.corp.google.com>
On 2018/8/14 6:14, Bjorn Helgaas wrote:
> On Sat, Aug 11, 2018 at 09:27:42PM +0800, Pu Wen wrote:
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index 2950223..d0e98a9 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -511,6 +511,8 @@
>> #define PCI_DEVICE_ID_AMI_MEGARAID 0x9010
>> #define PCI_DEVICE_ID_AMI_MEGARAID2 0x9060
>>
>> +#define PCI_VENDOR_ID_HYGON 0x1d94
>
> Please add this entry so pci_ids.h remains sorted by Vendor ID, then Device
> ID, as the comment at the top suggests.
Thanks for the suggestion. Will place PCI_VENDOR_ID_HYGON between
PCI_VENDOR_ID_AMAZON(0x1d0f) and PCI_VENDOR_ID_TEKRAM(0x1de1) in next
patch set.
Pu Wen
>
> With that changed,
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com> # pci_ids.h
>
>> #define PCI_VENDOR_ID_AMD 0x1022
>> #define PCI_DEVICE_ID_AMD_K8_NB 0x1100
>> #define PCI_DEVICE_ID_AMD_K8_NB_ADDRMAP 0x1101
>> --
>> 2.7.4
>>
prev parent reply other threads:[~2018-08-14 4:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-11 13:25 [PATCH v3 00/17] Add support for Hygon Dhyana Family 18h processor Pu Wen
2018-08-11 13:27 ` [PATCH v3 07/17] x86/pci: add Hygon PCI vendor and northbridge support Pu Wen
2018-08-13 22:14 ` Bjorn Helgaas
2018-08-14 4:56 ` Pu Wen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec0ef867-3254-9e17-bf37-de697e9d0709@hygon.cn \
--to=puwen@hygon.cn \
--cc=bp@alien8.de \
--cc=helgaas@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).