From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C261C04AB1 for ; Fri, 10 May 2019 02:22:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77C992183F for ; Fri, 10 May 2019 02:22:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726842AbfEJCWW (ORCPT ); Thu, 9 May 2019 22:22:22 -0400 Received: from smtprelay0074.hostedemail.com ([216.40.44.74]:35196 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726835AbfEJCWW (ORCPT ); Thu, 9 May 2019 22:22:22 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id F0A9C1802912A; Fri, 10 May 2019 02:22:20 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: death90_88875195d6303 X-Filterd-Recvd-Size: 2829 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Fri, 10 May 2019 02:22:18 +0000 (UTC) Message-ID: Subject: Re: [PATCH 02/10] PCI/PME: Replace dev_printk(KERN_DEBUG) with dev_info() From: Joe Perches To: Bjorn Helgaas Cc: Andy Shevchenko , Frederick Lawler , Mika Westerberg , Lukas Wunner , Andy Shevchenko , Keith Busch , Dongdong Liu , Sven Van Asbroeck , linux-pci@vger.kernel.org, Linux Kernel Mailing List Date: Thu, 09 May 2019 19:22:16 -0700 In-Reply-To: <20190509211226.GC235064@google.com> References: <20190509141456.223614-1-helgaas@kernel.org> <20190509141456.223614-3-helgaas@kernel.org> <69ff0a66d8c68f9e1adc8308847541e9566fe23e.camel@perches.com> <20190509211226.GC235064@google.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, 2019-05-09 at 16:12 -0500, Bjorn Helgaas wrote: > On Thu, May 09, 2019 at 11:31:04AM -0700, Joe Perches wrote: > > On Thu, 2019-05-09 at 20:35 +0300, Andy Shevchenko wrote: > > > On Thu, May 9, 2019 at 5:18 PM Bjorn Helgaas wrote: > > > > Replace dev_printk(KERN_DEBUG) with dev_info() or dev_err() to be more > > > > consistent with other logging. > > > > > > > > These could be converted to dev_dbg(), but that depends on > > > > CONFIG_DYNAMIC_DEBUG and DEBUG, and we want most of these messages to > > > > *always* be in the dmesg log. > > > > > > > > Also, use dev_fmt() to add the service name. Example output change: > > > > > > > > - pcieport 0000:80:10.0: Signaling PME with IRQ ... > > > > + pcieport 0000:80:10.0: PME: Signaling with IRQ ... > > > > + pci_info(port, "interrupt generated for non-existent device %02x:%02x.%d\n", > > > > + busnr, PCI_SLOT(devfn), PCI_FUNC(devfn)); > > > > + pci_info(port, "Spurious native interrupt!\n"); > > > > + pci_info(port, "Signaling with IRQ %d\n", srv->irq); > > > > Why change the logging level? > > Why not use #define DEBUG and use pci_dbg ? > > What would the benefit of using DEBUG be? It makes the _dbg output unconditional or possible to be disabled via dynamic_debug > I don't want these > particular messages to be conditional.