linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v2 3/5] pci/aer: Export cper_print_aer() for CXL driver logging
       [not found] ` <20230323213808.398039-4-terry.bowman@amd.com>
@ 2023-03-23 22:20   ` Terry Bowman
  2023-03-23 22:26     ` Sathyanarayanan Kuppuswamy
  0 siblings, 1 reply; 3+ messages in thread
From: Terry Bowman @ 2023-03-23 22:20 UTC (permalink / raw)
  To: alison.schofield, vishal.l.verma, ira.weiny, bwidawsk,
	dan.j.williams, dave.jiang, Jonathan.Cameron, linux-cxl,
	rrichter, mahesh, oohall, linux-pci
  Cc: linux-kernel, bhelgaas

Adding PCI reviewers.

https://lore.kernel.org/all/20230323213808.398039-1-terry.bowman@amd.com/

On 3/23/23 16:38, Terry Bowman wrote:
> The CXL driver plans to use cper_print_aer() for restricted CXL host
> (RCH) logging. cper_print_aer() is not exported and as a result is not
> available to the CXL driver or other loadable modules. Export
> cper_print_aer() making it available to CXL and other loadable modules.
> 
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> Cc: Mahesh J Salgaonkar <mahesh@linux.ibm.com>
> Cc: "Oliver O'Halloran" <oohall@gmail.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
> ---
>  drivers/pci/pcie/aer.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index 625f7b2cafe4..7f0f52d094a4 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -809,6 +809,7 @@ void cper_print_aer(struct pci_dev *dev, int aer_severity,
>  	trace_aer_event(dev_name(&dev->dev), (status & ~mask),
>  			aer_severity, tlp_header_valid, &aer->header_log);
>  }
> +EXPORT_SYMBOL_GPL(cper_print_aer);
>  #endif
>  
>  /**

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 3/5] pci/aer: Export cper_print_aer() for CXL driver logging
  2023-03-23 22:20   ` [PATCH v2 3/5] pci/aer: Export cper_print_aer() for CXL driver logging Terry Bowman
@ 2023-03-23 22:26     ` Sathyanarayanan Kuppuswamy
  2023-04-14 20:41       ` Terry Bowman
  0 siblings, 1 reply; 3+ messages in thread
From: Sathyanarayanan Kuppuswamy @ 2023-03-23 22:26 UTC (permalink / raw)
  To: Terry Bowman, alison.schofield, vishal.l.verma, ira.weiny,
	bwidawsk, dan.j.williams, dave.jiang, Jonathan.Cameron,
	linux-cxl, rrichter, mahesh, oohall, linux-pci
  Cc: linux-kernel, bhelgaas



On 3/23/23 3:20 PM, Terry Bowman wrote:
> Adding PCI reviewers.
> 
> https://lore.kernel.org/all/20230323213808.398039-1-terry.bowman@amd.com/

> 
> On 3/23/23 16:38, Terry Bowman wrote:
>> The CXL driver plans to use cper_print_aer() for restricted CXL host
>> (RCH) logging. cper_print_aer() is not exported and as a result is not
>> available to the CXL driver or other loadable modules. Export
>> cper_print_aer() making it available to CXL and other loadable modules.
>>
>> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
>> Cc: Mahesh J Salgaonkar <mahesh@linux.ibm.com>
>> Cc: "Oliver O'Halloran" <oohall@gmail.com>
>> Cc: Bjorn Helgaas <bhelgaas@google.com>
>> Cc: linux-pci@vger.kernel.org
>> ---

Looks fine to me.

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>


>>  drivers/pci/pcie/aer.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
>> index 625f7b2cafe4..7f0f52d094a4 100644
>> --- a/drivers/pci/pcie/aer.c
>> +++ b/drivers/pci/pcie/aer.c
>> @@ -809,6 +809,7 @@ void cper_print_aer(struct pci_dev *dev, int aer_severity,
>>  	trace_aer_event(dev_name(&dev->dev), (status & ~mask),
>>  			aer_severity, tlp_header_valid, &aer->header_log);
>>  }
>> +EXPORT_SYMBOL_GPL(cper_print_aer);
>>  #endif
>>  
>>  /**

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 3/5] pci/aer: Export cper_print_aer() for CXL driver logging
  2023-03-23 22:26     ` Sathyanarayanan Kuppuswamy
@ 2023-04-14 20:41       ` Terry Bowman
  0 siblings, 0 replies; 3+ messages in thread
From: Terry Bowman @ 2023-04-14 20:41 UTC (permalink / raw)
  To: Sathyanarayanan Kuppuswamy, alison.schofield, vishal.l.verma,
	ira.weiny, bwidawsk, dan.j.williams, dave.jiang,
	Jonathan.Cameron, linux-cxl, rrichter, mahesh, oohall, linux-pci
  Cc: linux-kernel, bhelgaas

Thanks Sathya.

On 3/23/23 17:26, Sathyanarayanan Kuppuswamy wrote:
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-04-14 20:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20230323213808.398039-1-terry.bowman@amd.com>
     [not found] ` <20230323213808.398039-4-terry.bowman@amd.com>
2023-03-23 22:20   ` [PATCH v2 3/5] pci/aer: Export cper_print_aer() for CXL driver logging Terry Bowman
2023-03-23 22:26     ` Sathyanarayanan Kuppuswamy
2023-04-14 20:41       ` Terry Bowman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).