From: Leonard Crestez <leonard.crestez@nxp.com>
To: "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>
Cc: "A.s. Dong" <aisheng.dong@nxp.com>,
"Joao.Pinto@synopsys.com" <Joao.Pinto@synopsys.com>,
Richard Zhu <hongxing.zhu@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Anson Huang <anson.huang@nxp.com>,
"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
dl-linux-imx <linux-imx@nxp.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>
Subject: Re: [RESEND] PCI: imx: Initial imx7d pm support
Date: Tue, 28 Aug 2018 13:00:02 +0000 [thread overview]
Message-ID: <efcb160f08bb53620ba0570e55dbb9190275aeb0.camel@nxp.com> (raw)
In-Reply-To: <20180828100758.GA27217@e107981-ln.cambridge.arm.com>
On Tue, 2018-08-28 at 11:07 +0100, Lorenzo Pieralisi wrote:
> On Mon, Aug 27, 2018 at 02:28:37PM +0300, Leonard Crestez wrote:
> > On imx7d the pcie-phy power domain is turned off in suspend and this can
> > make the system hang after resume when attempting any read from PCI.
> >
> > Fix this by adding minimal suspend/resume code from the nxp internal
> > tree. This will prepare for powering down on suspend and reset the block
> > on resume.
> >
> > Code is only for imx7d but a very similar sequence can be used for
> > other socs.
> >
> > The original author is mostly Richard Zhu <hongxing.zhu@nxp.com>, this
> > patch adjusts the code to the upstream imx7d implemention using reset
> > controls and power domains.
>
> I will add a Suggested-by: replacing this paragraph, it is always better
> to add proper tags rather than credit hidden in commit logs messages.
Isn't "Originally-by:" a better tag for this?
> > Some dependencies in this area are complicated but as far as I know
> > including this patch without others should not break anything that was
> > not already broken. Since this is a patch for something that has never
> > worked before it should be treated as a feature not a bugfix.
>
> Ok, so I consider this v4.20 material, please shout if it has to be
> sent as a fix, I do not think so given what we discussed above.
Thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-08-28 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 11:28 [RESEND] PCI: imx: Initial imx7d pm support Leonard Crestez
2018-08-28 10:07 ` Lorenzo Pieralisi
2018-08-28 13:00 ` Leonard Crestez [this message]
2018-08-28 14:55 ` Lorenzo Pieralisi
2018-09-03 13:52 ` Leonard Crestez
2018-09-17 10:33 ` Lorenzo Pieralisi
2018-09-17 10:33 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efcb160f08bb53620ba0570e55dbb9190275aeb0.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=Joao.Pinto@synopsys.com \
--cc=aisheng.dong@nxp.com \
--cc=andrew.smirnov@gmail.com \
--cc=anson.huang@nxp.com \
--cc=bhelgaas@google.com \
--cc=fabio.estevam@nxp.com \
--cc=hongxing.zhu@nxp.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).