From: James Ettle <james@ettle.org.uk>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "吳昊澄 Ricky" <ricky_wu@realtek.com>,
"Rui Feng" <rui_feng@realsil.com.cn>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Len Brown" <lenb@kernel.org>,
"Puranjay Mohan" <puranjay12@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Jacopo De Simoi" <wilderkde@gmail.com>
Subject: Re: rtsx_pci not restoring ASPM state after suspend/resume
Date: Mon, 27 Jul 2020 20:52:25 +0100 [thread overview]
Message-ID: <f02332767323fc3ecccea13dd47ecfff12526112.camel@ettle.org.uk> (raw)
In-Reply-To: <20200727141438.GA1743062@bjorn-Precision-5520>
On Mon, 2020-07-27 at 09:14 -0500, Bjorn Helgaas wrote:
> I don't know the connection between ASPM and package C-states, so I
> need to simplify this even more. All I want to do right now is
> verify
> that if we don't have any outside influences on the ASPM
> configuration
> (eg, no manual changes and no udev rules), it stays the same across
> suspend/resume.
Basically this started from me observing deep package C-states weren't
being used, until I went and fiddled with the ASPM state of the
rtsx_pci card reader under sysfs -- so phenomenological poking on my
part.
> So let's read the ASPM state directly from the
> hardware like this:
>
> sudo lspci -vvs 00:1d.0 | egrep "^0|Lnk|L1|LTR|snoop"
> sudo lspci -vvs 01:00 | egrep "^0|Lnk|L1|LTR|snoop"
>
> Can you try that before and after suspend/resume?
I've attached these to the bugzilla entry at:
https://bugzilla.kernel.org/show_bug.cgi?id=208117
Spoiler: With no udev rules or suspend hooks, things are the same
before and after suspend/resume. One thing I do see (both before and
after) is that ASPM L0s and L1 is enabled for the card reader, but
disabled for the ethernet chip (does r8169 fiddle with ASPM too?).
[Oddly when I set ASPM (e.g. using udev) the lspci tools show ASPM
enabled after a suspend/resume, but still no deep package C-states
until I manually fiddle via sysfs on the card reader. Sorry if this
only muddies the water further!]
Thanks,
-James
next prev parent reply other threads:[~2020-07-27 19:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 16:56 rtsx_pci not restoring ASPM state after suspend/resume Bjorn Helgaas
2020-07-23 17:12 ` Bjorn Helgaas
2020-07-24 7:16 ` 吳昊澄 Ricky
2020-07-24 23:13 ` Bjorn Helgaas
2020-07-25 20:27 ` James Ettle
2020-07-27 14:14 ` Bjorn Helgaas
2020-07-27 19:52 ` James Ettle [this message]
2020-07-27 21:47 ` Bjorn Helgaas
2020-07-28 5:46 ` 吳昊澄 Ricky
2020-07-28 20:57 ` James Ettle
2020-07-28 23:06 ` Bjorn Helgaas
2020-08-02 16:30 ` James Ettle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f02332767323fc3ecccea13dd47ecfff12526112.camel@ettle.org.uk \
--to=james@ettle.org.uk \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=puranjay12@gmail.com \
--cc=ricky_wu@realtek.com \
--cc=rui_feng@realsil.com.cn \
--cc=wilderkde@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).