linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Andree <matthias.andree@gmx.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Paul Menzel <pmenzel@molgen.mpg.de>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org,
	Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Subject: Re: [Regression] pcie_wait_for_link_delay (1132.853 ms @ 5039.414431)
Date: Tue, 6 Aug 2019 21:56:27 +0200	[thread overview]
Message-ID: <f1093e5c-2b90-c61c-7fed-437abda6ec6a@gmx.de> (raw)
In-Reply-To: <20190806113154.GS2548@lahna.fi.intel.com>

Mika,

reviewing the code in your commit, can we double-check the "!" in "if
(!pdev->imm_ready)" here?

> static int get_downstream_delay(struct pci_bus *bus)
> {
>         struct pci_dev *pdev;
>         int min_delay = 100;
>         int max_delay = 0;
>
>         list_for_each_entry(pdev, &bus->devices, bus_list) {
>                 if (!pdev->imm_ready)

I have zero clue of PCI (Express), but reading other parts of your patch,
I think min_delay should be zeroed if imm_ready is 1 (currently it is
zeroed if imm_ready == 0),
unless the header file has a misleading comment.

(I had tried removing the ! but that didn't fix my system.)

>                         min_delay = 0;
>                 else if (pdev->d3cold_delay < min_delay)
>                         min_delay = pdev->d3cold_delay;
>                 if (pdev->d3cold_delay > max_delay)
>                         max_delay = pdev->d3cold_delay;
>         }
>
>         return max(min_delay, max_delay);
> }

Regards,
Matthias


  parent reply	other threads:[~2019-08-06 19:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-06  9:20 [Regression] pcie_wait_for_link_delay (1132.853 ms @ 5039.414431) Paul Menzel
2019-08-06  9:36 ` Mika Westerberg
2019-08-06  9:57   ` Paul Menzel
2019-08-06 11:31     ` Mika Westerberg
2019-08-06 14:02       ` Paul Menzel
2019-08-06 14:15         ` Mika Westerberg
2019-08-06 19:56       ` Matthias Andree [this message]
2019-08-07 10:06         ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1093e5c-2b90-c61c-7fed-437abda6ec6a@gmx.de \
    --to=matthias.andree@gmx.de \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=nicholas.johnson-opensource@outlook.com.au \
    --cc=pmenzel@molgen.mpg.de \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).