* pci_lost_interrupt still needed?
@ 2020-07-28 19:20 Heiner Kallweit
2020-07-28 20:21 ` Bjorn Helgaas
0 siblings, 1 reply; 4+ messages in thread
From: Heiner Kallweit @ 2020-07-28 19:20 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci
Seems that pci_lost_interrupt() has no user. Do we still need this function?
Same applies for related enum pci_lost_interrupt_reason.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: pci_lost_interrupt still needed?
2020-07-28 19:20 pci_lost_interrupt still needed? Heiner Kallweit
@ 2020-07-28 20:21 ` Bjorn Helgaas
2020-07-28 20:28 ` Heiner Kallweit
0 siblings, 1 reply; 4+ messages in thread
From: Bjorn Helgaas @ 2020-07-28 20:21 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: Bjorn Helgaas, linux-pci
On Tue, Jul 28, 2020 at 09:20:34PM +0200, Heiner Kallweit wrote:
> Seems that pci_lost_interrupt() has no user. Do we still need this function?
> Same applies for related enum pci_lost_interrupt_reason.
If there's no user, remove it. Bonus points if you look up the
removal of the last use.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: pci_lost_interrupt still needed?
2020-07-28 20:21 ` Bjorn Helgaas
@ 2020-07-28 20:28 ` Heiner Kallweit
2020-07-28 20:50 ` Bjorn Helgaas
0 siblings, 1 reply; 4+ messages in thread
From: Heiner Kallweit @ 2020-07-28 20:28 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Bjorn Helgaas, linux-pci
On 28.07.2020 22:21, Bjorn Helgaas wrote:
> On Tue, Jul 28, 2020 at 09:20:34PM +0200, Heiner Kallweit wrote:
>> Seems that pci_lost_interrupt() has no user. Do we still need this function?
>> Same applies for related enum pci_lost_interrupt_reason.
>
> If there's no user, remove it. Bonus points if you look up the
> removal of the last use.
>
It was introduced in 2.6.27, and apparently there never has been a single user.
So I'll submit a patch to remove it.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: pci_lost_interrupt still needed?
2020-07-28 20:28 ` Heiner Kallweit
@ 2020-07-28 20:50 ` Bjorn Helgaas
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2020-07-28 20:50 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: Bjorn Helgaas, linux-pci
On Tue, Jul 28, 2020 at 10:28:08PM +0200, Heiner Kallweit wrote:
> On 28.07.2020 22:21, Bjorn Helgaas wrote:
> > On Tue, Jul 28, 2020 at 09:20:34PM +0200, Heiner Kallweit wrote:
> >> Seems that pci_lost_interrupt() has no user. Do we still need this function?
> >> Same applies for related enum pci_lost_interrupt_reason.
> >
> > If there's no user, remove it. Bonus points if you look up the
> > removal of the last use.
> >
> It was introduced in 2.6.27, and apparently there never has been a single user.
> So I'll submit a patch to remove it.
Strange. Please include the commit that added it and cc: the author.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-28 20:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 19:20 pci_lost_interrupt still needed? Heiner Kallweit
2020-07-28 20:21 ` Bjorn Helgaas
2020-07-28 20:28 ` Heiner Kallweit
2020-07-28 20:50 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).