From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>,
"Woods, Brian" <Brian.Woods@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
Clemens Ladisch <clemens@ladisch.de>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>, Pu Wen <puwen@hygon.cn>,
Jia Zhang <qianyue.zj@alibaba-inc.com>,
Takashi Iwai <tiwai@suse.de>, Andy Whitcroft <apw@canonical.com>,
Colin Ian King <colin.king@canonical.com>,
Myron Stowe <myron.stowe@redhat.com>,
Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies
Date: Wed, 07 Nov 2018 15:44:10 -0800 [thread overview]
Message-ID: <f854c74c307aa8f7cf482f5e4e63cf03f3dc12ca.camel@linux.intel.com> (raw)
In-Reply-To: <9e4da173ba2978e1c16839162dd927c5ea0fdc36.camel@linux.intel.com>
On Wed, 2018-11-07 at 15:30 -0800, Srinivas Pandruvada wrote:
> [...]
>
> > Sure, you can't *force* OEMs to supply a given ACPI device, but you
> > can certainly say "if you want this functionality, supply INT3401
> > devices." That's what you do with PNP0A03 (PCI host bridges), for
> > example. If an OEM doesn't supply PNP0A03 devices, the system can
> > boot just fine as long as you don't need PCI.
> >
> > This model of using the PCI IDs forces OS vendors to release
> > updates
> > for every new platform. I guess you must have considered that and
> > decided whatever benefit you're getting was worth the cost.
>
> Not worth cost. This is a pain. Every release we end up adding a
> single
> line change to many drivers adding a PCI device id.
> Since there is no unique class_mask for PCI device for these devices,
> we need to add device_id for each generation even if there is no
> change.
> Instead if we have some feature to say don't enumerate for PCI device
> id < X and a black list, it will save lot of work.
This still needs some work on our internal PCI device allocation scheme
, where we can reserve a block of ids for a PCI device for same
functionality from generation to generation.
Thanks,
Srinivas
next prev parent reply other threads:[~2018-11-07 23:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 18:11 [PATCH 0/4] Update DF/SMN access and k10temp for AMD F17h M30h Woods, Brian
2018-11-02 18:11 ` [PATCH 1/4] k10temp: x86/amd_nb: consolidate shared device IDs Woods, Brian
2018-11-02 18:24 ` Guenter Roeck
2018-11-02 18:11 ` [PATCH 2/4] x86/amd_nb: add support for newer PCI topologies Woods, Brian
2018-11-02 19:59 ` Bjorn Helgaas
2018-11-02 23:29 ` Borislav Petkov
2018-11-05 21:45 ` Bjorn Helgaas
2018-11-05 21:56 ` Borislav Petkov
2018-11-06 21:42 ` Bjorn Helgaas
2018-11-06 22:00 ` Borislav Petkov
2018-11-06 23:20 ` Bjorn Helgaas
2018-11-07 9:18 ` Borislav Petkov
2018-11-07 13:38 ` Bjorn Helgaas
2018-11-07 16:07 ` Borislav Petkov
2018-11-07 17:10 ` Bjorn Helgaas
2018-11-07 17:17 ` Borislav Petkov
2018-11-07 19:50 ` Woods, Brian
2018-11-07 13:51 ` Guenter Roeck
2018-11-07 17:16 ` Bjorn Helgaas
2018-11-07 19:15 ` Srinivas Pandruvada
2018-11-07 21:31 ` Bjorn Helgaas
2018-11-07 22:42 ` Srinivas Pandruvada
2018-11-07 23:14 ` Bjorn Helgaas
2018-11-07 23:30 ` Srinivas Pandruvada
2018-11-07 23:44 ` Srinivas Pandruvada [this message]
2018-11-08 1:40 ` Guenter Roeck
2018-11-08 13:59 ` Bjorn Helgaas
2018-11-05 19:38 ` Borislav Petkov
2018-11-05 20:33 ` Woods, Brian
2018-11-05 21:42 ` Borislav Petkov
2018-11-05 23:32 ` Woods, Brian
2018-11-06 8:27 ` Borislav Petkov
2018-11-02 18:11 ` [PATCH 3/4] x86/amd_nb: add PCI device IDs for F17h M30h Woods, Brian
2018-11-02 18:11 ` [PATCH 4/4] hwmon: k10temp: add support for AMD F17h M30h CPUs Woods, Brian
2018-11-02 18:26 ` Guenter Roeck
2018-11-05 20:32 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f854c74c307aa8f7cf482f5e4e63cf03f3dc12ca.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=Brian.Woods@amd.com \
--cc=apw@canonical.com \
--cc=bp@alien8.de \
--cc=clemens@ladisch.de \
--cc=colin.king@canonical.com \
--cc=helgaas@kernel.org \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@redhat.com \
--cc=myron.stowe@redhat.com \
--cc=puwen@hygon.cn \
--cc=qianyue.zj@alibaba-inc.com \
--cc=sumeet.r.pawnikar@intel.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).