From: poza@codeaurora.org
To: Keith Busch <keith.busch@intel.com>
Cc: Linux PCI <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Sinan Kaya <okaya@codeaurora.org>,
linux-pci-owner@vger.kernel.org
Subject: Re: [PATCHv2 7/7] PCI/DPC: Print AER status in DPC event handling
Date: Thu, 17 May 2018 20:34:13 +0530 [thread overview]
Message-ID: <f9bb09d1d73b19231017a42258eef340@codeaurora.org> (raw)
In-Reply-To: <12ab6f9ef1ab79fd09ff7ec583e1d2da@codeaurora.org>
On 2018-05-17 20:32, poza@codeaurora.org wrote:
> On 2018-04-02 21:52, Keith Busch wrote:
>> A DPC enabled device suppresses ERR_(NON)FATAL messages, preventing
>> the
>> AER handler from reporting error details. If the DPC trigger reason
>> says
>> the downstream port detected the error, this patch has the DPC driver
>> collect the AER uncorrectable status for logging, then clears the
>> status.
>>
>> Signed-off-by: Keith Busch <keith.busch@intel.com>
>> ---
>> drivers/pci/pcie/pcie-dpc.c | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/pcie/pcie-dpc.c b/drivers/pci/pcie/pcie-dpc.c
>> index e12837ee4f1c..76f963a5089e 100644
>> --- a/drivers/pci/pcie/pcie-dpc.c
>> +++ b/drivers/pci/pcie/pcie-dpc.c
>> @@ -85,6 +85,7 @@ static void dpc_wait_link_inactive(struct dpc_dev
>> *dpc)
>>
>> static void dpc_work(struct work_struct *work)
>> {
>> + struct aer_err_info info;
>> struct dpc_dev *dpc = container_of(work, struct dpc_dev, work);
>> struct pci_dev *dev, *temp, *pdev = dpc->dev->port;
>> struct pci_bus *parent = pdev->subordinate;
>> @@ -108,8 +109,12 @@ static void dpc_work(struct work_struct *work)
>> (ext_reason == 1) ? "software trigger" :
>> "reserved error");
>>
>> - if (dpc->rp_extensions && reason == 3 && ext_reason == 0)
>> + if (dpc->rp_extensions && reason == 3 && ext_reason == 0) {
>> pio_status = dpc_process_rp_pio_error(dpc);
>> + } else if (reason == 0 && aer_get_device_error_info(pdev, &info)) {
>> + aer_print_error(pdev, &info);
>> + pci_cleanup_aer_uncorrect_error_status(pdev);
>> + }
>>
>> pci_lock_rescan_remove();
>> list_for_each_entry_safe_reverse(dev, temp, &parent->devices,
>
>
> I am not sure if this series is in pursuit. but was wondering why do
> we need to clear aer status in DPC (when DPC is triggered)?
> because
>
> 6.2.10 for Downstream Port Containment:
>
> When DPC is triggered due to receipt of an uncorrectable error
> Message,
> the Requester ID from the Message is recorded in the DPC Error
> Source ID register and that Message is discarded and not forwarded
> Upstream. When DPC is triggered by an unmasked uncorrectable error,
> that error will not be signaled with an uncorrectable error Message,
> even if otherwise enabled.
>
> so when DPC is active, the msg is discarded and not forwarded to
> upstream.
> which means that we should find AER status set in RP or Switch.
>
> Regards,
> Oza.
Correction: which means that we should *not* find AER status set in RP
or Switch.
next prev parent reply other threads:[~2018-05-17 15:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 16:21 [PATCHv2 0/7] DPC updates Keith Busch
2018-04-02 16:21 ` [PATCHv2 1/7] PCI/DPC: Enable ERR_COR Keith Busch
2018-04-02 21:23 ` Bjorn Helgaas
2018-04-02 23:09 ` Keith Busch
2018-04-03 14:16 ` Bjorn Helgaas
2018-04-03 14:31 ` Rafael J. Wysocki
2018-04-03 14:37 ` Keith Busch
2018-04-02 16:21 ` [PATCHv2 2/7] PCI/DPC: Fix PCI legacy interrupt acknowledgement Keith Busch
2018-04-03 20:38 ` Bjorn Helgaas
2018-04-03 23:04 ` Bjorn Helgaas
2018-04-04 8:13 ` Thomas Gleixner
2018-04-04 8:38 ` Lukas Wunner
2018-04-26 5:33 ` poza
2018-05-16 15:16 ` Timur Tabi
2018-05-16 21:04 ` Bjorn Helgaas
2018-04-02 16:21 ` [PATCHv2 3/7] PCI/DPC: Leave interrupts enabled while handling event Keith Busch
2018-04-02 16:22 ` [PATCHv2 4/7] PCI/DPC: Defer event handling to work queue Keith Busch
2018-04-02 16:22 ` [PATCHv2 5/7] PCI/DPC: Remove rp_pio_status from dpc struct Keith Busch
2018-04-02 16:22 ` [PATCHv2 6/7] PCI/AER: API for obtaining AER information Keith Busch
2018-04-09 10:03 ` David Laight
2018-04-09 14:37 ` Keith Busch
2018-04-02 16:22 ` [PATCHv2 7/7] PCI/DPC: Print AER status in DPC event handling Keith Busch
2018-05-17 15:02 ` poza
2018-05-17 15:04 ` poza [this message]
2018-06-19 21:31 ` [PATCHv2 0/7] DPC updates Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9bb09d1d73b19231017a42258eef340@codeaurora.org \
--to=poza@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-pci-owner@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).