* [PATCH] dt-bindings: PCI: rcar-pci-host: Document missing R-Car H1 support
@ 2021-04-29 12:44 Geert Uytterhoeven
2021-05-03 20:01 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2021-04-29 12:44 UTC (permalink / raw)
To: Marek Vasut, Yoshihiro Shimoda, Bjorn Helgaas, Rob Herring,
Lorenzo Pieralisi
Cc: linux-pci, linux-renesas-soc, devicetree, Geert Uytterhoeven
scripts/checkpatch.pl -f drivers/pci/controller/pcie-rcar-host.c:
WARNING: DT compatible string "renesas,pcie-r8a7779" appears un-documented -- check ./Documentation/devicetree/bindings/
#853: FILE: drivers/pci/controller/pcie-rcar-host.c:853:
+ { .compatible = "renesas,pcie-r8a7779",
Re-add the compatible value for R-Car H1, which was lost during the
json-schema conversion. Make the "resets" property optional on R-Car
H1, as it is not present yet on R-Car Gen1 SoCs.
Fixes: 0d69ce3c2c63d4db ("dt-bindings: PCI: rcar-pci-host: Convert bindings to json-schema")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This was never enabled in the upstream r8a7779.dtsi, but the Linux
driver does support it.
---
.../devicetree/bindings/pci/rcar-pci-host.yaml | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml b/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
index 4a2bcc0158e2d49a..8fdfbc763d704532 100644
--- a/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
@@ -17,6 +17,7 @@ allOf:
properties:
compatible:
oneOf:
+ - const: renesas,pcie-r8a7779 # R-Car H1
- items:
- enum:
- renesas,pcie-r8a7742 # RZ/G1H
@@ -74,7 +75,16 @@ required:
- clocks
- clock-names
- power-domains
- - resets
+
+if:
+ not:
+ properties:
+ compatible:
+ contains:
+ const: renesas,pcie-r8a7779
+then:
+ required:
+ - resets
unevaluatedProperties: false
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: PCI: rcar-pci-host: Document missing R-Car H1 support
2021-04-29 12:44 [PATCH] dt-bindings: PCI: rcar-pci-host: Document missing R-Car H1 support Geert Uytterhoeven
@ 2021-05-03 20:01 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2021-05-03 20:01 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: linux-pci, Marek Vasut, linux-renesas-soc, devicetree,
Rob Herring, Lorenzo Pieralisi, Bjorn Helgaas, Yoshihiro Shimoda
On Thu, 29 Apr 2021 14:44:09 +0200, Geert Uytterhoeven wrote:
> scripts/checkpatch.pl -f drivers/pci/controller/pcie-rcar-host.c:
>
> WARNING: DT compatible string "renesas,pcie-r8a7779" appears un-documented -- check ./Documentation/devicetree/bindings/
> #853: FILE: drivers/pci/controller/pcie-rcar-host.c:853:
> + { .compatible = "renesas,pcie-r8a7779",
>
> Re-add the compatible value for R-Car H1, which was lost during the
> json-schema conversion. Make the "resets" property optional on R-Car
> H1, as it is not present yet on R-Car Gen1 SoCs.
>
> Fixes: 0d69ce3c2c63d4db ("dt-bindings: PCI: rcar-pci-host: Convert bindings to json-schema")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This was never enabled in the upstream r8a7779.dtsi, but the Linux
> driver does support it.
> ---
> .../devicetree/bindings/pci/rcar-pci-host.yaml | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-03 20:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29 12:44 [PATCH] dt-bindings: PCI: rcar-pci-host: Document missing R-Car H1 support Geert Uytterhoeven
2021-05-03 20:01 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).