From: Yicong Yang <yangyicong@huawei.com>
To: Leo Yan <leo.yan@linaro.org>, Yicong Yang <yangyicong@hisilicon.com>
Cc: <gregkh@linuxfoundation.org>,
<alexander.shishkin@linux.intel.com>, <james.clark@arm.com>,
<will@kernel.org>, <robin.murphy@arm.com>, <acme@kernel.org>,
<jonathan.cameron@huawei.com>, <john.garry@huawei.com>,
<helgaas@kernel.org>, <lorenzo.pieralisi@arm.com>,
<mathieu.poirier@linaro.org>, <suzuki.poulose@arm.com>,
<mark.rutland@arm.com>, <joro@8bytes.org>,
<shameerali.kolothum.thodi@huawei.com>, <peterz@infradead.org>,
<mingo@redhat.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-pci@vger.kernel.org>, <linux-perf-users@vger.kernel.org>,
<iommu@lists.linux-foundation.org>, <prime.zeng@huawei.com>,
<liuqi115@huawei.com>, <zhangshaokun@hisilicon.com>,
<linuxarm@huawei.com>
Subject: Re: [PATCH v9 5/8] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver
Date: Mon, 27 Jun 2022 16:18:36 +0800 [thread overview]
Message-ID: <fb55fdab-3ad6-a21a-315a-9dc404b35f11@huawei.com> (raw)
In-Reply-To: <20220627020256.GB143063@leoy-ThinkPad-X240s>
On 2022/6/27 10:02, Leo Yan wrote:
> On Mon, Jun 06, 2022 at 07:55:52PM +0800, Yicong Yang wrote:
>> From: Qi Liu <liuqi115@huawei.com>
>>
>> HiSilicon PCIe tune and trace device (PTT) could dynamically tune
>> the PCIe link's events, and trace the TLP headers).
>>
>> This patch add support for PTT device in perf tool, so users could
>> use 'perf record' to get TLP headers trace data.
>>
>> Signed-off-by: Qi Liu <liuqi115@huawei.com>
>> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
>
> Just one minor comment.
>
> [...]
>
>> diff --git a/tools/perf/util/hisi-ptt.h b/tools/perf/util/hisi-ptt.h
>> new file mode 100644
>> index 000000000000..2db9b4056214
>> --- /dev/null
>> +++ b/tools/perf/util/hisi-ptt.h
>> @@ -0,0 +1,19 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * HiSilicon PCIe Trace and Tuning (PTT) support
>> + * Copyright (c) 2022 HiSilicon Technologies Co., Ltd.
>> + */
>> +
>> +#ifndef INCLUDE__PERF_HISI_PTT_H__
>> +#define INCLUDE__PERF_HISI_PTT_H__
>> +
>> +#define HISI_PTT_PMU_NAME "hisi_ptt"
>> +#define HISI_PTT_AUXTRACE_PRIV_SIZE sizeof(u64)
>> +
>> +struct auxtrace_record *hisi_ptt_recording_init(int *err,
>> + struct perf_pmu *hisi_ptt_pmu);
>> +
>> +int hisi_ptt_process_auxtrace_info(union perf_event *event,
>> + struct perf_session *session);
>
> The function hisi_ptt_process_auxtrace_info() is introduced by next
> patch for support PTT decoding, for good practice (e.g. keep
> bisection), it's good to introduce function declaration and definition
> in one patch.
>
Thanks for catching this. There's something wrong when doing the patch splitting.
Will fix this!
> With this fixing, this patch looks good to me:
>
> Reviewed-by: Leo Yan <leo.yan@linaro.org>
>
Thanks.
next prev parent reply other threads:[~2022-06-27 8:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 11:55 [PATCH v9 0/8] Add support for HiSilicon PCIe Tune and Trace device Yicong Yang
2022-06-06 11:55 ` [PATCH v9 1/8] iommu/arm-smmu-v3: Make default domain type of HiSilicon PTT device to identity Yicong Yang
2022-06-06 11:55 ` [PATCH v9 2/8] hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe Tune and Trace device Yicong Yang
2022-07-07 17:59 ` Mathieu Poirier
2022-07-11 17:41 ` Mathieu Poirier
2022-07-11 17:46 ` Mathieu Poirier
2022-07-12 13:10 ` Yicong Yang
2022-06-06 11:55 ` [PATCH v9 3/8] hwtracing: hisi_ptt: Add tune " Yicong Yang
2022-06-06 11:55 ` [PATCH v9 4/8] perf tool: arm: Refactor event list iteration in auxtrace_record__init() Yicong Yang
2022-06-27 1:19 ` Leo Yan
2022-06-06 11:55 ` [PATCH v9 5/8] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver Yicong Yang
2022-06-27 2:02 ` Leo Yan
2022-06-27 8:18 ` Yicong Yang [this message]
2022-06-06 11:55 ` [PATCH v9 6/8] perf tool: Add support for parsing HiSilicon PCIe Trace packet Yicong Yang
2022-06-06 11:55 ` [PATCH v9 7/8] docs: trace: Add HiSilicon PTT device driver documentation Yicong Yang
2022-07-06 17:57 ` Mathieu Poirier
2022-07-07 11:43 ` Yicong Yang
2022-07-07 16:20 ` Mathieu Poirier
2022-07-12 12:38 ` Yicong Yang
2022-07-12 15:02 ` Mathieu Poirier
2022-06-06 11:55 ` [PATCH v9 8/8] MAINTAINERS: Add maintainer for HiSilicon PTT driver Yicong Yang
2022-06-27 11:18 ` [PATCH v9 0/8] Add support for HiSilicon PCIe Tune and Trace device Yicong Yang
2022-06-27 13:12 ` Greg KH
2022-06-27 13:25 ` Yicong Yang
2022-06-27 14:01 ` Peter Zijlstra
2022-06-28 7:17 ` Yicong Yang
2022-06-29 16:43 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb55fdab-3ad6-a21a-315a-9dc404b35f11@huawei.com \
--to=yangyicong@huawei.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=joro@8bytes.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuqi115@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=prime.zeng@huawei.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).