From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
To: Wu Bo <wubo40@huawei.com>, <rjw@rjwysocki.net>, <lenb@kernel.org>,
<bhelgaas@google.com>
Cc: <linux-acpi@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
linfeilong <linfeilong@huawei.com>
Subject: Re: [PATCH] pci: fix memory leak when virtio pci hotplug
Date: Tue, 23 Mar 2021 16:14:03 +0800 [thread overview]
Message-ID: <fc38cd3b-9e48-6787-afe6-1c991a7186ca@huawei.com> (raw)
In-Reply-To: <768d4a60-7442-fbdd-9c00-cc927a54d340@huawei.com>
friendly ping..
On 2021/3/22 10:43, Wu Bo wrote:
> On 2021/3/21 23:29, Zhiqiang Liu wrote:
>> From: Feilong Lin <linfeilong@huawei.com>
>>
>> Repeated hot-plugging of pci devices for a virtual
>> machine driven by virtio, we found that there is a
>> leak in kmalloc-4k, which was confirmed as the memory
>> of the pci_device structure. Then we found out that
>> it was missing pci_dev_put() after pci_get_slot() in
>> enable_slot() of acpiphp_glue.c.
>>
>> Signed-off-by: Feilong Lin <linfeilong@huawei.com>
>> Reviewed-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
>> ---
>> drivers/pci/hotplug/acpiphp_glue.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c
>> index 3365c93abf0e..f031302ad401 100644
>> --- a/drivers/pci/hotplug/acpiphp_glue.c
>> +++ b/drivers/pci/hotplug/acpiphp_glue.c
>> @@ -533,6 +533,7 @@ static void enable_slot(struct acpiphp_slot *slot, bool bridge)
>> slot->flags &= ~SLOT_ENABLED;
>> continue;
>> }
>> + pci_dev_put(dev);
>> }
>> }
>>
> Reviewed-by: Wu Bo <wubo40@huawei.com>
>
> .
next prev parent reply other threads:[~2021-03-23 8:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 15:29 [PATCH] pci: fix memory leak when virtio pci hotplug Zhiqiang Liu
2021-03-22 2:43 ` Wu Bo
2021-03-23 8:14 ` Zhiqiang Liu [this message]
2021-03-23 18:24 ` Bjorn Helgaas
2021-03-25 0:52 ` Zhiqiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc38cd3b-9e48-6787-afe6-1c991a7186ca@huawei.com \
--to=liuzhiqiang26@huawei.com \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linfeilong@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=wubo40@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).