From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed To: Bjorn Helgaas , Benjamin Herrenschmidt Cc: poza@codeaurora.org, Thomas Tai , bhelgaas@google.com, keith.busch@intel.com, linux-pci@vger.kernel.org, linux-pci-owner@vger.kernel.org, Sam Bobroff References: <1534179088-44219-1-git-send-email-thomas.tai@oracle.com> <1534179088-44219-2-git-send-email-thomas.tai@oracle.com> <51f4b387d9bd96a42d526a6a029fc43b@codeaurora.org> <903394c04d6ad468ed06dc0a779200e7555345a7.camel@kernel.crashing.org> <6cb069038530757f31f3dd60328c7e30@codeaurora.org> <20180819021922.GE128050@bhelgaas-glaptop.roam.corp.google.com> From: Sinan Kaya Message-ID: Date: Sun, 19 Aug 2018 17:41:32 -0400 MIME-Version: 1.0 In-Reply-To: <20180819021922.GE128050@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=utf-8; format=flowed List-ID: On 8/18/2018 10:19 PM, Bjorn Helgaas wrote: >> Bjorn, please revert all of those changes. > Please send the appropriate patches and we'll go from there. > I'm also catching up on this thread. I don't think revert is the way to go. There is certainly value in Oza's code to make error handling common. We started by following the existing error handling scheme and then moved onto the stop/remove behavior based on Bjorn's feedback. The right thing is for Oza to rework the code to go back to original error handling callback mechanism. That should be a trivial change.