From: Florian Fainelli <f.fainelli@gmail.com>
To: Cyril Brulebois <kibi@debian.org>, Jim Quinlan <jim2101024@gmail.com>
Cc: linux-pci@vger.kernel.org,
"Nicolas Saenz Julienne" <nsaenz@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Phil Elwell" <phil@raspberrypi.com>,
bcm-kernel-feedback-list@broadcom.com,
james.quinlan@broadcom.com,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] PCI: brcmstb: CLKREQ# accomodations of downstream device
Date: Thu, 13 Apr 2023 07:58:51 -0700 [thread overview]
Message-ID: <ff2c73b7-3654-d871-de8b-7180c123f05d@gmail.com> (raw)
In-Reply-To: <20230413143935.pmbyjk2boxl3rwne@mraw.org>
On 4/13/2023 7:39 AM, Cyril Brulebois wrote:
> Hi Jim,
>
> Jim Quinlan <jim2101024@gmail.com> (2023-04-11):
>> […]
>> This property has already been in use by Raspian Linux, but this
>> immplementation adds more details and discerns between (a) and (b)
> ^^^^^^^^^^^^^^^
> implementation
>
>> automatically.
>>
>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217276
>> Signed-off-by: Jim Quinlan <jim2101024@gmail.com>
>
> Sorry, it seems like my initial tests with v1 (applied on top of
> v6.3-rc5-137-gf2afccfefe7b) weren't thorough enough, and I'm seeing the
> same problems with v2 (applied on top of v6.3-rc6-46-gde4664485abb):
> - same setup as in https://bugzilla.kernel.org/show_bug.cgi?id=217276
> - the kernel panic is indeed gone;
> - a USB keyboard connected on that SupaHub PCIe-to-multiple-USB adapter
> isn't seen by the kernel;
> - a USB memory stick connected on the same adapter isn't seen by the
> kernel either;
> - of course both USB devices are confirmed to work fine if they're
> plugged directly on the CM4's USB ports.
>
> Logs with v2:
>
> root@cm4:~# dmesg|grep -i pci
> [ 0.610997] PCI: CLS 0 bytes, default 64
> [ 1.664886] shpchp: Standard Hot Plug PCI Controller Driver version: 0.4
> [ 1.672083] brcm-pcie fd500000.pcie: host bridge /scb/pcie@7d500000 ranges:
> [ 1.679125] brcm-pcie fd500000.pcie: No bus range found for /scb/pcie@7d500000, using [bus 00-ff]
> [ 1.688279] brcm-pcie fd500000.pcie: MEM 0x0600000000..0x0603ffffff -> 0x00f8000000
> [ 1.696463] brcm-pcie fd500000.pcie: IB MEM 0x0000000000..0x00ffffffff -> 0x0400000000
> [ 1.705282] brcm-pcie fd500000.pcie: PCI host bridge to bus 0000:00
> [ 1.711629] pci_bus 0000:00: root bus resource [bus 00-ff]
> [ 1.717172] pci_bus 0000:00: root bus resource [mem 0x600000000-0x603ffffff] (bus address [0xf8000000-0xfbffffff])
> [ 1.727653] pci 0000:00:00.0: [14e4:2711] type 01 class 0x060400
> [ 1.733768] pci 0000:00:00.0: PME# supported from D0 D3hot
> [ 1.740235] pci 0000:00:00.0: bridge configuration invalid ([bus 00-00]), reconfiguring
> [ 1.855826] brcm-pcie fd500000.pcie: CLKREQ# ignored; no ASPM
> [ 1.863666] brcm-pcie fd500000.pcie: link up, 5.0 GT/s PCIe x1 (SSC)
> [ 1.870115] pci 0000:01:00.0: [1912:0014] type 00 class 0x0c0330
> [ 1.876205] pci 0000:01:00.0: reg 0x10: [mem 0x00000000-0x00001fff 64bit]
> [ 1.883177] pci 0000:01:00.0: PME# supported from D0 D3hot
> [ 1.888881] pci_bus 0000:01: busn_res: [bus 01-ff] end is updated to 01
> [ 1.895581] pci 0000:00:00.0: BAR 14: assigned [mem 0x600000000-0x6000fffff]
> [ 1.902707] pci 0000:01:00.0: BAR 0: assigned [mem 0x600000000-0x600001fff 64bit]
> [ 1.910279] pci 0000:00:00.0: PCI bridge to [bus 01]
> [ 1.915293] pci 0000:00:00.0: bridge window [mem 0x600000000-0x6000fffff]
> [ 1.922412] pcieport 0000:00:00.0: enabling device (0000 -> 0002)
> [ 1.928633] pcieport 0000:00:00.0: PME: Signaling with IRQ 23
> [ 1.934609] pcieport 0000:00:00.0: AER: enabled with IRQ 23
> [ 1.940340] pci 0000:01:00.0: enabling device (0000 -> 0002)
> [ 6.946090] pci 0000:01:00.0: xHCI HW not ready after 5 sec (HC bug?) status = 0x1801
> [ 6.954026] pci 0000:01:00.0: quirk_usb_early_handoff+0x0/0x968 took 4896180 usecs
>
> Please let me know what I can do to help.
Could you please attach your .config so we can check a few things?
--
Florian
next prev parent reply other threads:[~2023-04-13 14:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 16:59 [PATCH v2 0/3] PCI: brcmstb: CLKREQ# accomodations of downstream device Jim Quinlan
2023-04-11 16:59 ` [PATCH v2 1/3] dt-bindings: PCI: brcmstb: Add two optional props Jim Quinlan
2023-04-12 8:09 ` Krzysztof Kozlowski
2023-04-12 11:49 ` Florian Fainelli
2023-04-12 11:56 ` Krzysztof Kozlowski
2023-04-12 14:14 ` Jim Quinlan
2023-04-12 15:37 ` Rob Herring
2023-04-12 16:12 ` Florian Fainelli
2023-04-18 18:35 ` Rob Herring
2023-04-21 19:07 ` Konstantin Ryabitsev
2023-04-14 20:14 ` Bjorn Helgaas
2023-04-11 16:59 ` [PATCH v2 2/3] PCI: brcmstb: CLKREQ# accomodations of downstream device Jim Quinlan
2023-04-13 14:39 ` Cyril Brulebois
2023-04-13 14:57 ` Jim Quinlan
[not found] ` <20230413200646.ddgsoqgmaae343nl@mraw.org>
2023-04-14 12:14 ` Jim Quinlan
2023-04-14 12:27 ` Florian Fainelli
2023-04-14 13:31 ` Jim Quinlan
2023-04-14 16:19 ` Cyril Brulebois
2023-04-19 14:23 ` Jim Quinlan
2023-04-19 15:57 ` Cyril Brulebois
2023-04-13 14:58 ` Florian Fainelli [this message]
2023-04-14 20:27 ` Bjorn Helgaas
2023-04-14 20:33 ` Florian Fainelli
2023-04-17 21:41 ` Bjorn Helgaas
2023-04-14 23:14 ` Jim Quinlan
2023-04-11 16:59 ` [PATCH v2 3/3] PCI: brcmstb: Set PCIe transaction completion timeout Jim Quinlan
2023-04-12 0:26 ` Cyril Brulebois
2023-04-13 18:40 ` [PATCH v2 0/3] PCI: brcmstb: CLKREQ# accomodations of downstream device Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff2c73b7-3654-d871-de8b-7180c123f05d@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=james.quinlan@broadcom.com \
--cc=jim2101024@gmail.com \
--cc=kibi@debian.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lpieralisi@kernel.org \
--cc=nsaenz@kernel.org \
--cc=phil@raspberrypi.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).