From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B56DC433E2 for ; Fri, 28 Aug 2020 21:04:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F8632075B for ; Fri, 28 Aug 2020 21:04:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726396AbgH1VEa (ORCPT ); Fri, 28 Aug 2020 17:04:30 -0400 Received: from nikam.ms.mff.cuni.cz ([195.113.20.16]:42370 "EHLO nikam.ms.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726338AbgH1VE3 (ORCPT ); Fri, 28 Aug 2020 17:04:29 -0400 X-Greylist: delayed 474 seconds by postgrey-1.27 at vger.kernel.org; Fri, 28 Aug 2020 17:04:29 EDT Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 2587) id 9FD4A282AC2; Fri, 28 Aug 2020 22:56:28 +0200 (CEST) Date: Fri, 28 Aug 2020 22:56:28 +0200 From: Martin =?utf-8?B?TWFyZcWh?= To: Bjorn Helgaas Cc: Dongdong Liu , linux-pci@vger.kernel.org Subject: Re: [PATCH] lspci: Decode 10-Bit Tag Requester Enable Message-ID: References: <1596266480-52789-1-git-send-email-liudongdong3@huawei.com> <20200828164931.GA2161257@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200828164931.GA2161257@bjorn-Precision-5520> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hello! > And we have a bit of a mess in the names here. There are a bunch of > "PCI_EXP_DEV2_*" names that would be "PCI_EXP_DEVCTL2_*" if they > followed the convention. You didn't start that trend, so I'm just > pointing it out in case you or Martin want to clean it up. When I add > names I try to use the same name between the Linux kernel source [1] > and lspci. Yes, could you please clean it up? Otherwise it's OK. Martin