From: "Martin Mareš" <mj@ucw.cz>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Bjorn Helgaas" <helgaas@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Matthew Wilcox" <willy@infradead.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH pciutils 3/5] libpci: generic: Implement SUBSYS also for PCI_HEADER_TYPE_BRIDGE
Date: Fri, 21 Jan 2022 15:40:49 +0100 [thread overview]
Message-ID: <mj+md-20220121.144016.17855.nikam@ucw.cz> (raw)
In-Reply-To: <20220121135718.27172-4-pali@kernel.org>
Hello!
> + case PCI_HEADER_TYPE_BRIDGE:
> + if (pci_read_word(d, PCI_STATUS) & PCI_STATUS_CAP_LIST)
> + {
> + byte been_there[256];
> + int where, id;
> +
> + memset(been_there, 0, 256);
> + where = pci_read_byte(d, PCI_CAPABILITY_LIST) & ~3;
> + while (where && !been_there[where]++)
Please don't. There should be a single implementation of capability list
walking in libpci, not everybody doing his own.
Martin
next prev parent reply other threads:[~2022-01-21 14:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 13:57 [PATCH pciutils 0/5] Support for PROGIF, REVID and SUBSYS Pali Rohár
2022-01-21 13:57 ` [PATCH pciutils 1/5] libpci: Add new options for pci_fill_info: " Pali Rohár
2022-01-21 13:57 ` [PATCH pciutils 2/5] libpci: generic: Implement PROGIF, REVID and SUBSYS support Pali Rohár
2022-01-21 13:57 ` [PATCH pciutils 3/5] libpci: generic: Implement SUBSYS also for PCI_HEADER_TYPE_BRIDGE Pali Rohár
2022-01-21 14:40 ` Martin Mareš [this message]
2022-01-21 16:11 ` Pali Rohár
2022-01-21 20:43 ` Martin Mareš
2022-01-21 13:57 ` [PATCH pciutils 4/5] libpci: sysfs: Implement PROGIF, REVID and SUBSYS support Pali Rohár
2022-01-21 13:57 ` [PATCH pciutils 5/5] lspci: Retrieve prog if, subsystem ids and revision id via libpci Pali Rohár
2022-01-21 14:40 ` [PATCH pciutils 0/5] Support for PROGIF, REVID and SUBSYS Martin Mareš
2022-01-21 15:12 ` Pali Rohár
2022-01-21 15:15 ` Martin Mareš
2022-01-21 15:26 ` Pali Rohár
2022-01-21 15:29 ` Martin Mareš
2022-01-21 15:35 ` Pali Rohár
2022-01-21 15:38 ` Martin Mareš
2022-01-21 15:45 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mj+md-20220121.144016.17855.nikam@ucw.cz \
--to=mj@ucw.cz \
--cc=helgaas@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=pali@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).