From: "Martin Mareš" <mj@ucw.cz>
To: Alexey Kardashevskiy <aik@amd.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH pciutils v2] ls-ecaps: Correct the link state reporting
Date: Tue, 23 Apr 2024 14:26:00 +0200 [thread overview]
Message-ID: <mj+md-20240423.122538.98992.albireo@ucw.cz> (raw)
In-Reply-To: <20240422111447.143973-1-aik@amd.com>
Hi!
> PCIe r6.0, sec 7.9.26.4.2 "Link IDE Stream Status Register defines"
> the link state as:
>
> 0000b Insecure
> 0010b Secure
>
> The same definition applies to selective streams as well.
> The existing code wrongly assumes "secure" is 0001b, fix that for both
> link and selective streams.
>
> While at this, add missing "Selective IDE for Configuration Requests Enable".
>
> Fixes: 42fc4263ec0e ("ls-ecaps: Add decode support for IDE Extended Capability")
> Signed-off-by: Alexey Kardashevskiy <aik@amd.com>
> ---
> Changes:
> v2:
> * fixed memory and RID base/limit values parsing
> * added missing "IDE for Configuration Requests Enable"
> * fixed the example
Fine, but please update the commit message to include the fix of base/limit.
Martin
prev parent reply other threads:[~2024-04-23 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 11:14 [PATCH pciutils v2] ls-ecaps: Correct the link state reporting Alexey Kardashevskiy
2024-04-23 12:26 ` Martin Mareš [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mj+md-20240423.122538.98992.albireo@ucw.cz \
--to=mj@ucw.cz \
--cc=aik@amd.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).