From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7675C433FE for ; Mon, 9 May 2022 09:28:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236016AbiEIJbq (ORCPT ); Mon, 9 May 2022 05:31:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236554AbiEII5g (ORCPT ); Mon, 9 May 2022 04:57:36 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 304AE202B26; Mon, 9 May 2022 01:53:36 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 9125E21B3D; Mon, 9 May 2022 08:53:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1652086413; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dfcvUUdqksgvYc8rVDLHC5DOBo/kU2XO+VX1eeG4aV8=; b=A34L+qWnS4KTuUIJIOdn/Oy0lRYM0k4tu6TprpUGGmO4q2IG6PgANqhT26b8ERa1UPxmL3 +i1ltyuQDR6b3JXdcEzOXVh1KYWhR2Zwt+tTJHHP3RNo/us6IFdzvOCkW7gcDMpTyzgCvx xJwG93EwlvMl01wRmSewhq2A5QaBHXU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1652086413; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dfcvUUdqksgvYc8rVDLHC5DOBo/kU2XO+VX1eeG4aV8=; b=UKYq4/y/oVRFARjOiTG0UlZFJ7CNosy5fO4czqcNJLtcbGcYGz4OJwlbgEGhzVQm3iPfhB Fx+12pZoeT2rmkDQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 79C5C2C141; Mon, 9 May 2022 08:53:33 +0000 (UTC) Date: Mon, 09 May 2022 10:53:33 +0200 Message-ID: From: Takashi Iwai To: Niklas Schnelle Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, Arnd Bergmann , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org (moderated list:SOUND) Subject: Re: [RFC v2 31/39] sound: add HAS_IOPORT dependencies In-Reply-To: <20220429135108.2781579-57-schnelle@linux.ibm.com> References: <20220429135108.2781579-1-schnelle@linux.ibm.com> <20220429135108.2781579-57-schnelle@linux.ibm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, 29 Apr 2022 15:50:54 +0200, Niklas Schnelle wrote: > > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. For SND_OPL3_LIB this adds its first > dependency so drivers currently selecting it unconditionally need to > depend on it instead. > > Co-developed-by: Arnd Bergmann > Signed-off-by: Niklas Schnelle > --- > sound/drivers/Kconfig | 5 ++++ > sound/isa/Kconfig | 44 ++++++++++++++--------------- > sound/pci/Kconfig | 64 +++++++++++++++++++++++++++++-------------- > 3 files changed, 70 insertions(+), 43 deletions(-) > > diff --git a/sound/drivers/Kconfig b/sound/drivers/Kconfig > index ca4cdf666f82..4d250e619786 100644 > --- a/sound/drivers/Kconfig > +++ b/sound/drivers/Kconfig > @@ -1,10 +1,12 @@ > # SPDX-License-Identifier: GPL-2.0-only > config SND_MPU401_UART > tristate > + depends on HAS_IOPORT > select SND_RAWMIDI > > config SND_OPL3_LIB > tristate > + depends on HAS_IOPPORT > select SND_TIMER > select SND_HWDEP > select SND_SEQ_DEVICE if SND_SEQUENCER != n Both of those are the items to be reverse-selected, so cannot fulfill the dependency with depends-on. That is, the items that select those should have the dependency on HAS_IOPORT instead. That is, a change like below: > --- a/sound/isa/Kconfig > +++ b/sound/isa/Kconfig > @@ -31,7 +31,7 @@ if SND_ISA > > config SND_ADLIB > tristate "AdLib FM card" > - select SND_OPL3_LIB > + depends on SND_OPL3_LIB ... won't work. CONFIG_SND_OPL3_LIB is not enabled by itself but only to be selected. thanks, Takashi