linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Al Grant <al.grant@foss.arm.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	acme@kernel.org
Subject: Re: [PATCH] perf: correct SNOOPX field offset
Date: Wed, 26 Aug 2020 11:26:31 -0300	[thread overview]
Message-ID: <20200826142631.GA5351@redhat.com> (raw)
In-Reply-To: <20200825174043.GQ1509399@tassilo.jf.intel.com>

Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu:
> On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote:
> > perf_event.h has macros that define the field offsets in the
> > data_src bitmask in perf records. The SNOOPX and REMOTE offsets
> > were both 37. These are distinct fields, and the bitfield layout
> > in perf_mem_data_src confirms that SNOOPX should be at offset 38.
> 
> Looks good.
> 
> Reviewed-by: Andi Kleen <ak@linux.intel.com>
> 
> Probably should have a Fixes: header

Please do so, find the patch that introduced the error, add the Fixes
tag, will help me not having to do it myself :-)

- Arnaldo

  reply	other threads:[~2020-08-26 14:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24  9:28 [PATCH] perf: correct SNOOPX field offset Al Grant
2020-08-25 17:40 ` Andi Kleen
2020-08-26 14:26   ` Arnaldo Carvalho de Melo [this message]
2020-08-26 14:33     ` Al Grant
2020-09-01 15:02       ` Arnaldo Carvalho de Melo
2020-09-01 15:05         ` Al Grant
2020-09-01 15:06         ` Arnaldo Carvalho de Melo
2020-09-01 15:12           ` peterz
2020-09-01 15:58             ` Arnaldo Carvalho de Melo
2020-09-01 17:34               ` Peter Zijlstra
2020-08-26 11:24 ` Mark Rutland
2020-09-21 20:46 Al Grant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200826142631.GA5351@redhat.com \
    --to=acme@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=al.grant@foss.arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).