From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Kajol Jain <kjain@linux.ibm.com>,
peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, pc@us.ibm.com,
namhyung@kernel.org, ak@linux.intel.com, yao.jin@linux.intel.com,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
irogers@google.com, maddy@linux.ibm.com,
ravi.bangoria@linux.ibm.com, john.garry@huawei.com
Subject: Re: [PATCH v9 0/5] powerpc/perf: Add json file support for hv_24x7 core level events
Date: Thu, 10 Sep 2020 09:20:48 -0300 [thread overview]
Message-ID: <20200910122048.GD4018363@kernel.org> (raw)
In-Reply-To: <20200907100529.GF1199773@krava>
Em Mon, Sep 07, 2020 at 12:05:29PM +0200, Jiri Olsa escreveu:
> On Mon, Sep 07, 2020 at 12:11:28PM +0530, Kajol Jain wrote:
> > Patchset enhance current runtime parameter support. It introduces new
> > fields like "PerChip" and "PerCore" similar to the field "PerPkg" which is
> > used to specify perpkg events.
> >
> > The "PerCore" and "PerChip" specifies whether its core or chip events.
> > Based on which we can decide which runtime parameter user want to
> > access. Now character '?' can refers different parameter based on user
> > requirement.
> >
> > Initially, every time we want to add new terms like chip, core, thread
> > etc, we need to create corrsponding fields in pmu_events and event
> > struct.
> > This patchset adds an enum called 'aggr_mode_class' which store all these
> > aggregation like perchip/percore. It also adds new field 'AggregationMode'
> > to capture these terms.
> > Now, if user wants to add any new term, they just need to add it in
> > the enum defined.
> >
> > This patchset also adds changes of adding new structure
> > called 'json_event' inside jevents.c
> > file to improve the callback prototype inside jevent file.
> > Initially, whenever user want to add new field, they need to update
> > in all function callback which makes it more and more complex with
> > increased number of parmeters.
> > With this change, we just need to add it in new structure 'json_event'.
> > link to the RFC patch: https://lkml.org/lkml/2020/8/25/217
> >
> > Changelog:
> > v8 -> v9
> > - Free aggr_mode memory [Jiri Olsa].
>
> Acked-by: Jiri Olsa <jolsa@redhat.com>
Thanks, applied.
- Arnaldo
prev parent reply other threads:[~2020-09-10 12:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 6:41 [PATCH v9 0/5] powerpc/perf: Add json file support for hv_24x7 core level events Kajol Jain
2020-09-07 6:41 ` [PATCH v9 1/5] perf/jevents: Remove jevents.h file Kajol Jain
2020-09-07 6:41 ` [PATCH v9 2/5] perf/jevents: Add new structure to pass json fields Kajol Jain
2020-09-07 6:41 ` [PATCH v9 3/5] perf jevents: Add support for parsing perchip/percore events Kajol Jain
2020-09-07 6:41 ` [PATCH v9 4/5] perf/tools: Pass pmu_event structure as a parameter for arch_get_runtimeparam Kajol Jain
2020-09-07 6:41 ` [PATCH v9 5/5] perf/tools/pmu_events/powerpc: Add hv_24x7 core level metric events Kajol Jain
2020-09-07 10:05 ` [PATCH v9 0/5] powerpc/perf: Add json file support for hv_24x7 core level events Jiri Olsa
2020-09-10 12:20 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910122048.GD4018363@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).