[BUG] perf probe can't remove probes

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Clark Williams <williams@redhat.com>,
	linux-perf-users@vger.kernel.org
Subject: [BUG] perf probe can't remove probes
Date: Wed, 25 Nov 2020 14:27:55 -0300	[thread overview]
Message-ID: <20201125172755.GA53351@kernel.org> (raw)

Masami, have you stumbled on this already?

[root@seventh ~]# perf probe security_locked_down%return 'ret=$retval'
Added new event:
  probe:security_locked_down__return (on security_locked_down%return with ret=$retval)

You can now use it in all perf tools, such as:

	perf record -e probe:security_locked_down__return -aR sleep 1

[root@seventh ~]# perf probe security_locked_down what
Added new event:
  probe:security_locked_down (on security_locked_down with what)

You can now use it in all perf tools, such as:

	perf record -e probe:security_locked_down -aR sleep 1

[root@seventh ~]#

[root@seventh ~]# uname -r
5.10.0-rc3.bpfsign+
[root@seventh ~]# perf probe -l
  probe:security_locked_down (on security_locked_down@git/bpf/security/security.c with what)
  probe:security_locked_down__return (on security_locked_down%return@git/bpf/security/security.c with ret)
[root@seventh ~]# perf probe -D '*:*'
Semantic error :There is non-digit char in line number.

 Usage: perf probe [<options>] 'PROBEDEF' ['PROBEDEF' ...]
    or: perf probe [<options>] --add 'PROBEDEF' [--add 'PROBEDEF' ...]
    or: perf probe [<options>] --del '[GROUP:]EVENT' ...
    or: perf probe --list [GROUP:]EVENT ...
    or: perf probe [<options>] --line 'LINEDESC'
    or: perf probe [<options>] --vars 'PROBEPOINT'
    or: perf probe [<options>] --funcs

    -D, --definition <[EVENT=]FUNC[@SRC][+OFF|%return|:RL|;PT]|SRC:AL|SRC;PT [[NAME=]ARG ...]>
                          Show trace event definition of given traceevent for k/uprobe_events.
[root@seventh ~]# perf probe probe:security_locked_down
Semantic error :There is non-digit char in line number.
  Error: Command Parse Error.
[root@seventh ~]# perf probe probe:security_locked_down__return
Semantic error :There is non-digit char in line number.
  Error: Command Parse Error.
[root@seventh ~]# cat /sys/kernel/debug/kprobes/
blacklist  enabled    list
[root@seventh ~]# cat /sys/kernel/debug/kprobes/list
ffffffff8248b350  k  security_locked_down+0x0    [FTRACE]
ffffffff8248b350  r  security_locked_down+0x0    [FTRACE]
[root@seventh ~]#

[root@seventh ~]# cat /etc/fedora-release
Fedora release 33 (Thirty Three)
[root@seventh ~]# gcc -v
Using built-in specs.
COLLECT_GCC=/usr/bin/gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/10/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-redhat-linux
Configured with: ../configure --enable-bootstrap --enable-languages=c,c++,fortran,objc,obj-c++,ada,go,d,lto --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-shared --enable-threads=posix --enable-checking=release --enable-multilib --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-gcc-major-version-only --with-linker-hash-style=gnu --enable-plugin --enable-initfini-array --with-isl --enable-offload-targets=nvptx-none --without-cuda-driver --enable-gnu-indirect-function --enable-cet --with-tune=generic --with-arch_32=i686 --build=x86_64-redhat-linux
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 10.2.1 20201016 (Red Hat 10.2.1-6) (GCC)
[root@seventh ~]# rpm -q elfutils
elfutils-0.182-1.fc33.x86_64
[root@seventh ~]#

- Arnaldo