linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Clark Williams <williams@redhat.com>,
	linux-perf-users@vger.kernel.org
Subject: Re: [BUG] perf probe can't remove probes
Date: Thu, 26 Nov 2020 14:26:03 -0300	[thread overview]
Message-ID: <20201126172603.GD53384@kernel.org> (raw)
In-Reply-To: <20201126092125.402257a8776637d6bd2e090c@kernel.org>

Em Thu, Nov 26, 2020 at 09:21:25AM +0900, Masami Hiramatsu escreveu:
> Hi Arnaldo,
> 
> On Wed, 25 Nov 2020 14:27:55 -0300
> Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> 
> > 
> > Masami, have you stumbled on this already?
> > 
> > [root@seventh ~]# perf probe security_locked_down%return 'ret=$retval'
> > Added new event:
> >   probe:security_locked_down__return (on security_locked_down%return with ret=$retval)
> > 
> > You can now use it in all perf tools, such as:
> > 
> > 	perf record -e probe:security_locked_down__return -aR sleep 1
> > 
> > [root@seventh ~]# perf probe security_locked_down what
> > Added new event:
> >   probe:security_locked_down (on security_locked_down with what)
> > 
> > You can now use it in all perf tools, such as:
> > 
> > 	perf record -e probe:security_locked_down -aR sleep 1
> > 
> > [root@seventh ~]#
> > 
> > 
> > [root@seventh ~]# uname -r
> > 5.10.0-rc3.bpfsign+
> > [root@seventh ~]# perf probe -l
> >   probe:security_locked_down (on security_locked_down@git/bpf/security/security.c with what)
> >   probe:security_locked_down__return (on security_locked_down%return@git/bpf/security/security.c with ret)
> > [root@seventh ~]# perf probe -D '*:*'
> > Semantic error :There is non-digit char in line number.
> > 
> >  Usage: perf probe [<options>] 'PROBEDEF' ['PROBEDEF' ...]
> >     or: perf probe [<options>] --add 'PROBEDEF' [--add 'PROBEDEF' ...]
> >     or: perf probe [<options>] --del '[GROUP:]EVENT' ...
> >     or: perf probe --list [GROUP:]EVENT ...
> >     or: perf probe [<options>] --line 'LINEDESC'
> >     or: perf probe [<options>] --vars 'PROBEPOINT'
> >     or: perf probe [<options>] --funcs
> > 
> >     -D, --definition <[EVENT=]FUNC[@SRC][+OFF|%return|:RL|;PT]|SRC:AL|SRC;PT [[NAME=]ARG ...]>
> >                           Show trace event definition of given traceevent for k/uprobe_events.
> 
> As you can see, "-D" is showing definition. Not delete. (*)
> Delete is "-d" or "--del".

Yeah, I was in a hurry and looked at just the first line right after the
command, didn't want to forget reporting it so sent the "bug" report,
d0h, sorry about the noise, using -d or --del works.

But having both -d and -D, in retrospect, wasn't such a good idea :-\

- Arnaldo
 
> (*) this option is for different version of kernel, remote-machine
> and boot-time tracing.
> 
> > [root@seventh ~]# perf probe probe:security_locked_down
> > Semantic error :There is non-digit char in line number.
> >   Error: Command Parse Error.
> > [root@seventh ~]# perf probe probe:security_locked_down__return
> > Semantic error :There is non-digit char in line number.
> >   Error: Command Parse Error.
> 
> Since you don't pass any option, both are for adding new probe event.
> 
> What happen if you run
> 
> $ perf probe -d "*:*"
> 
> ?
> 
> Thank you,
> 
> -- 
> Masami Hiramatsu <mhiramat@kernel.org>

-- 

- Arnaldo

  reply	other threads:[~2020-11-26 17:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 17:27 [BUG] perf probe can't remove probes Arnaldo Carvalho de Melo
2020-11-26  0:21 ` Masami Hiramatsu
2020-11-26 17:26   ` Arnaldo Carvalho de Melo [this message]
2020-12-16  0:16     ` Masami Hiramatsu
2020-12-16 13:59       ` Arnaldo Carvalho de Melo
2020-12-01 13:25   ` Arnaldo Carvalho de Melo
2020-12-01 13:43     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201126172603.GD53384@kernel.org \
    --to=acme@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).