From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6728C2B9F4 for ; Thu, 17 Jun 2021 18:42:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86A68613E1 for ; Thu, 17 Jun 2021 18:42:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232609AbhFQSok (ORCPT ); Thu, 17 Jun 2021 14:44:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232458AbhFQSoj (ORCPT ); Thu, 17 Jun 2021 14:44:39 -0400 Received: from mail-qv1-xf49.google.com (mail-qv1-xf49.google.com [IPv6:2607:f8b0:4864:20::f49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D808EC06175F for ; Thu, 17 Jun 2021 11:42:31 -0700 (PDT) Received: by mail-qv1-xf49.google.com with SMTP id 2-20020a0562140d62b02902357adaa890so3046563qvs.20 for ; Thu, 17 Jun 2021 11:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=PFZQwytkaiwWlIlKohYqf6fjHhndSooLEMwUFHht7ds=; b=iyJ1e2QDwkO2dM31gs2gGxDqbXMTnBTPHawrQ46ZYkK1iL09n0hHmRo50WUvVWMF1o j4i74zlkPXYgC9ZQTxakKY2nVhpaODFg8TpjOWOjtPqCOSjpleV/gByQbmj98wgYlYsO yWmn4LHLY1bbJw87u3Y4/6hUVR4xVy8fkz8WCUCHuASES/yhxsr8BMhA0szo/Xs9XKX+ vGHQTsCVj812n/TeIQeuWwu6R9kwVQ3IhDNEhmh2BIDjD7NbVboT9QT1adqLGA1y9njG E1SeuhymSiP6QdRYN7r8f4l9i6lTW/sGCCX2kV26XDTKmfDO3coo19/4fKOaodfvO02T ckzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=PFZQwytkaiwWlIlKohYqf6fjHhndSooLEMwUFHht7ds=; b=WqliMLSLoNzJBVZ9l4yzGkDl4DYX8HlR8xWiJM+QYrtQpnJgjmAAzaOU7CuuvmtPiK J6qAQi3nTIbLxRwuLEKcHQDa9+GpJFEoeuh/dhScYhhk1b/+CNXfS2numEm/EHfuNham 9dYdXf7DJyu+POEg8Pp/sykqJsCF2VmFC5ZIR1aGDVOir5ZdY/opXQ+hggV8TWoPqcFs Hn+8x9m9KM/AlCbeSmiEb2kRAmBNo/kKbyCB0UxuNxinrtAJ6Q1NlWEClcSDnnNzQVEv +zDhrSbBo9Uo66pvWwVT1/Rt9YB+JH4tgOBrjpSd8y/7liLvDNU808wonT1PccSbhtp+ 3PZA== X-Gm-Message-State: AOAM533dCesJQ/KLAV7VfiT8wOmP0mLiUMerqPUXjPQ8TEWqGS0p2IZe RDxcCKQiFCYotUHBwwuDIST8apoYay8R X-Google-Smtp-Source: ABdhPJxCHi9VcrdwhllY0LhoGwLekF7I6iEiE23gPOhHNruIdT2wgVP0bd5Vr4d54ca3YYS+iZblTXZdWg4a X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:202:ef90:beff:e92f:7ce0]) (user=irogers job=sendgmr) by 2002:a25:c243:: with SMTP id s64mr8032005ybf.171.1623955350902; Thu, 17 Jun 2021 11:42:30 -0700 (PDT) Date: Thu, 17 Jun 2021 11:42:14 -0700 In-Reply-To: <20210617184216.2075588-1-irogers@google.com> Message-Id: <20210617184216.2075588-2-irogers@google.com> Mime-Version: 1.0 References: <20210617184216.2075588-1-irogers@google.com> X-Mailer: git-send-email 2.32.0.288.g62a8d224e6-goog Subject: [PATCH 2/4] perf test: Pass the verbose option to shell tests From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Song Liu , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Cc: Ian Rogers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Having a verbose option will allow shell tests to provide extra failure details when the fail or skip. Signed-off-by: Ian Rogers --- tools/perf/tests/builtin-test.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c index cbbfe48ab802..a8160b1684de 100644 --- a/tools/perf/tests/builtin-test.c +++ b/tools/perf/tests/builtin-test.c @@ -577,11 +577,14 @@ struct shell_test { static int shell_test__run(struct test *test, int subdir __maybe_unused) { int err; - char script[PATH_MAX]; + char script[PATH_MAX + 3]; struct shell_test *st = test->priv; path__join(script, sizeof(script), st->dir, st->file); + if (verbose) + strncat(script, " -v", sizeof(script)); + err = system(script); if (!err) return TEST_OK; -- 2.32.0.288.g62a8d224e6-goog