From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB526C07E9B for ; Mon, 5 Jul 2021 23:26:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE30C61978 for ; Mon, 5 Jul 2021 23:26:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229783AbhGEX2w (ORCPT ); Mon, 5 Jul 2021 19:28:52 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:57629 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229942AbhGEX2u (ORCPT ); Mon, 5 Jul 2021 19:28:50 -0400 Received: (Authenticated sender: edwin@etorok.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 08462200004; Mon, 5 Jul 2021 23:26:10 +0000 (UTC) From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: linux-riscv@lists.infradead.org Cc: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-perf-users@vger.kernel.org Subject: [PATCH 1/4] tools/perf/arch/riscv: record registers needed for --call-graph=dwarf Date: Tue, 6 Jul 2021 00:25:21 +0100 Message-Id: <20210705232524.4024832-2-edwin@etorok.net> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210705232524.4024832-1-edwin@etorok.net> References: <20210705232524.4024832-1-edwin@etorok.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org For libdw-based callgraph sampling to work we need to sample registers. Tested on HiFive Unmatched with a trunk version of OCaml: ``` # perf record --user-regs=? available registers: pc ra sp gp tp t0 t1 t2 s0 s1 a0 a1 a2 a3 a4 a5 a6 a7 s2 s3 s4 s5 s6 s7 s8 s9 s10 s11 t3 t4 t5 t6 # sed -e 's/(\*\*//' -e 's/\*\*)//' \ testsuite/tests/misc-unsafe/almabench.ml >almabench_benchmark.ml # ocamlopt almabench_benchmark.ml -unsafe -o almabench_benchmark # perf record -e cpu-clock -v --call-graph=dwarf -F 99 \ ./almabench_benchmark callchain: type DWARF callchain: stack dump size 8192 nr_cblocks: 0 affinity: SYS mmap flush: 1 comp level: 0 mmap size 528384B mmap size 528384B Control descriptor is not initialized 0 17.00 -26.06 1 12.34 1.29 2 6.83 22.95 3 0.04 -1.26 4 2.30 12.54 5 2.93 14.35 6 21.27 -16.57 7 20.41 -19.04 [ perf record: Woken up 65 times to write data ] Looking at the vmlinux_path (8 entries long) Failed to open /proc/kcore. Note /proc/kcore requires CAP_SYS_RAWIO capability to access. Using /proc/kallsyms for symbols failed to write feature CPUDESC failed to write feature CPUID failed to write feature NUMA_TOPOLOGY failed to write feature MEM_TOPOLOGY [ perf record: Captured and wrote 16.265 MB perf.data (1997 samples) ] # perf script ... almabench_bench 1193 14816.399235: 10101010 cpu-clock: 3fbbd63d54 reduce_sincos+0x268 (inlined) 3fbbd63d54 __cos+0x268 (/lib/libm-2.33.so) 2aac4b261b Almabench_benchmark.planetpv+0x25f (/home/root/ocaml/almabench_benchmark) 2aac4b3e03 Almabench_benchmark.entry+0x12bb (/home/root/ocaml/almabench_benchmark) 2aac4b0097 caml_program+0x143 (/home/root/ocaml/almabench_benchmark) 2aac4e4e3d caml_start_program+0x71 (/home/root/ocaml/almabench_benchmark) 2aac4e5409 caml_startup_common+0x18f (/home/root/ocaml/almabench_benchmark) 2aac4e5465 caml_startup_exn+0x9 (inlined) 2aac4e5465 caml_startup+0x9 (inlined) 2aac4e5465 caml_main+0x9 (/home/root/ocaml/almabench_benchmark) 2aac4afe89 main+0x9 (/home/root/ocaml/almabench_benchmark) 3fbbc47b0b __libc_start_main+0x85 (/lib/libc-2.33.so) 2aac4afebb _start+0x2b (/home/root/ocaml/almabench_benchmark) ``` Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Jiri Olsa Cc: Namhyung Kim Cc: Paul Walmsley Cc: Palmer Dabbelt Cc: Albert Ou Cc: linux-perf-users@vger.kernel.org Cc: linux-riscv@lists.infradead.org Signed-off-by: Edwin Török --- tools/perf/arch/riscv/util/perf_regs.c | 32 ++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/tools/perf/arch/riscv/util/perf_regs.c b/tools/perf/arch/riscv/util/perf_regs.c index 2864e2e3776d..8c9f511e8322 100644 --- a/tools/perf/arch/riscv/util/perf_regs.c +++ b/tools/perf/arch/riscv/util/perf_regs.c @@ -2,5 +2,37 @@ #include "../../util/perf_regs.h" const struct sample_reg sample_reg_masks[] = { + SMPL_REG(pc, PERF_REG_RISCV_PC), + SMPL_REG(ra, PERF_REG_RISCV_RA), + SMPL_REG(sp, PERF_REG_RISCV_SP), + SMPL_REG(gp, PERF_REG_RISCV_GP), + SMPL_REG(tp, PERF_REG_RISCV_TP), + SMPL_REG(t0, PERF_REG_RISCV_T0), + SMPL_REG(t1, PERF_REG_RISCV_T1), + SMPL_REG(t2, PERF_REG_RISCV_T2), + SMPL_REG(s0, PERF_REG_RISCV_S0), + SMPL_REG(s1, PERF_REG_RISCV_S1), + SMPL_REG(a0, PERF_REG_RISCV_A0), + SMPL_REG(a1, PERF_REG_RISCV_A1), + SMPL_REG(a2, PERF_REG_RISCV_A2), + SMPL_REG(a3, PERF_REG_RISCV_A3), + SMPL_REG(a4, PERF_REG_RISCV_A4), + SMPL_REG(a5, PERF_REG_RISCV_A5), + SMPL_REG(a6, PERF_REG_RISCV_A6), + SMPL_REG(a7, PERF_REG_RISCV_A7), + SMPL_REG(s2, PERF_REG_RISCV_S2), + SMPL_REG(s3, PERF_REG_RISCV_S3), + SMPL_REG(s4, PERF_REG_RISCV_S4), + SMPL_REG(s5, PERF_REG_RISCV_S5), + SMPL_REG(s6, PERF_REG_RISCV_S6), + SMPL_REG(s7, PERF_REG_RISCV_S7), + SMPL_REG(s8, PERF_REG_RISCV_S8), + SMPL_REG(s9, PERF_REG_RISCV_S9), + SMPL_REG(s10, PERF_REG_RISCV_S10), + SMPL_REG(s11, PERF_REG_RISCV_S11), + SMPL_REG(t3, PERF_REG_RISCV_T3), + SMPL_REG(t4, PERF_REG_RISCV_T4), + SMPL_REG(t5, PERF_REG_RISCV_T5), + SMPL_REG(t6, PERF_REG_RISCV_T6), SMPL_REG_END }; -- 2.31.1